aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aurora ReviewBot <wfar...@apache.org>
Subject Re: Review Request 42953: Improve --read-json to handle multi-job files
Date Fri, 29 Jan 2016 06:14:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42953/#review116915
-----------------------------------------------------------



Master (0eb753d) is red with this patch.
  ./build-support/jenkins/build.sh

                           # If this fails, will raise an InvalidConfigError or other
exception and fail the test.
                     >     AuroraConfigLoader.loads_json(job_json_string)
                     
                     src/test/python/apache/aurora/config/test_loader.py:63: 
                     _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
                     .pants.d/python-setup/chroots/0ffa30cf850ad77bcb959bce6b299b3e46dbaada/apache/aurora/config/loader.py:79:
in loads_json
                         'jobs': [base_schema.Job(x) for x in parsed.get('jobs')]
                     .pants.d/python-setup/chroots/0ffa30cf850ad77bcb959bce6b299b3e46dbaada/.deps/pystachio-0.8.0-py2.py3-none-any.whl/pystachio/composite.py:160:
in __init__
                         self._update_schema_data(**arg)
                     .pants.d/python-setup/chroots/0ffa30cf850ad77bcb959bce6b299b3e46dbaada/.deps/pystachio-0.8.0-py2.py3-none-any.whl/pystachio/composite.py:180:
in _update_schema_data
                         self._schema_data[attr] = self._process_schema_attribute(attr,
value)
                     _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
                     
                     self = <[AttributeError("MesosJob has no attribute _scopes") raised
in repr()] SafeRepr object at 0x7f71e0a34440>
                     attr = 'unknown_attribute', value = 'foo bar baz'
                     
                         def _process_schema_attribute(self, attr, value):
                           if attr not in self.TYPEMAP:
                     >       raise AttributeError('Unknown schema attribute %s' % attr)
                     E       AttributeError: Unknown schema attribute unknown_attribute
                     
                     .pants.d/python-setup/chroots/0ffa30cf850ad77bcb959bce6b299b3e46dbaada/.deps/pystachio-0.8.0-py2.py3-none-any.whl/pystachio/composite.py:169:
AttributeError
                     _________________ test_load_json _________________
                     
                         def test_load_json():
                           env = AuroraConfigLoader.load(BytesIO(MESOS_CONFIG))
                           job = env['jobs'][0]
                           new_job = AuroraConfigLoader.loads_json(json.dumps(job.get()))
                     >     assert new_job == job
                     E     assert {'jobs': [MesosJob(health_check_config=HealthCheckConfig(initial_interval_secs=15.0,\n
  ...aints=ConstraintList()),\n         name=hello_world,\n         cluster=smf1-test)]} ==
MesosJob(health_check_config=HealthCheckConfig(initial_interval_secs=15.0,\n   ...aints=ConstraintList()),\n
        name=hello_world,\n         cluster=smf1-test)
                     
                     src/test/python/apache/aurora/config/test_loader.py:74: AssertionError
                      generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/src.test.python.apache.aurora.config.config.xml

                     ====== 2 failed, 26 passed in 3.78 seconds =======
                     
FAILURE


06:14:43 04:09   [complete]
               FAILURE


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Jan. 29, 2016, 5:28 a.m., Benjamin Staffin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42953/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2016, 5:28 a.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Bugs: AURORA-1577
>     https://issues.apache.org/jira/browse/AURORA-1577
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Still handles the old --read-json behavior of expecting a single job,
> but adds the ability to read files with a {"jobs": [job1, job2, ...]}
> schema like the pystachio format.
> 
> Also adds --read-json to the `aurora config load` command, as it is
> now useful there.
> 
> Fixes: AURORA-1577
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/config.py 73b556266183bf17463881b87cda107d07d79d71

>   src/main/python/apache/aurora/config/__init__.py 665e2cd08d4146e652b13bb82e04680315a1eebe

>   src/main/python/apache/aurora/config/loader.py a967b9dca353f5a70c89abee5d45220a9593c01a

> 
> Diff: https://reviews.apache.org/r/42953/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benjamin Staffin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message