aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joshua Cohen <jco...@apache.org>
Subject Re: Review Request 42922: Revert "Improving job update query performance."
Date Thu, 28 Jan 2016 22:25:01 GMT


> On Jan. 28, 2016, 10:23 p.m., Bill Farner wrote:
> > Retroactive - but please file and attach a ticket to this patch.
> 
> John Sirois wrote:
>     You owe me a Coke.

Yeah, as soon as we understand what wen't wrong we'll file a ticket and I'll link it here.
Immediate priority was to ensure no one else gets bit by this.


- Joshua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42922/#review116830
-----------------------------------------------------------


On Jan. 28, 2016, 10:15 p.m., Joshua Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42922/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2016, 10:15 p.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This reverts commit fee5943a95c4f08e148dc5f1366486a8c23d5773.
> 
> We discovered a bug when deploying this commit that caused corruption of the update store.
> 
> 
> Diffs
> -----
> 
>   src/jmh/java/org/apache/aurora/benchmark/JobUpdates.java 50044e1c38c712a52855dd96fa2a9de769d6c973

>   src/jmh/java/org/apache/aurora/benchmark/UpdateStoreBenchmarks.java 92849d9a82dcd6d5fe6cc452061bcdca31415f40

>   src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml
8438f7287b9a95a2cecd72c996b84901cabed4e1 
> 
> Diff: https://reviews.apache.org/r/42922/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message