aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bill Farner <wfar...@apache.org>
Subject Re: Review Request 42845: Enable H2 logging to slf4j.
Date Wed, 27 Jan 2016 18:41:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42845/#review116604
-----------------------------------------------------------


Ship it!




Fine to ship, suggested a bit of minor cleanup.


src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java (lines 118 - 119)
<https://reviews.apache.org/r/42845/#comment177666>

    Please change this to explain that level 4 indicates intent to use slf4j, and change the
link to
    http://www.h2database.com/html/features.html#other_logging



src/main/resources/logback.xml (line 21)
<https://reviews.apache.org/r/42845/#comment177674>

    This is really convenient!  For those curious, it generates this output, essentially echoing
the configuration:
    ```
    18:36:36,988 |-INFO in ch.qos.logback.classic.LoggerContext[default] - Found resource
[logback.xml] at [jar:file:/home/vagrant/aurora/dist/install/aurora-scheduler/lib/aurora-0.12
    .0-SNAPSHOT.jar!/logback.xml]
    18:36:37,074 |-INFO in ch.qos.logback.core.joran.spi.ConfigurationWatchList@25af5db5 -
URL [jar:file:/home/vagrant/aurora/dist/install/aurora-scheduler/lib/aurora-0.12.0-SNAPSHOT.
    jar!/logback.xml] is not of type file
    18:36:37,356 |-INFO in ch.qos.logback.core.joran.action.AppenderAction - About to instantiate
appender of type [ch.qos.logback.core.ConsoleAppender]
    18:36:37,366 |-INFO in ch.qos.logback.core.joran.action.AppenderAction - Naming appender
as [STDERR]
    18:36:37,508 |-INFO in ch.qos.logback.core.joran.action.NestedComplexPropertyIA - Assuming
default type [ch.qos.logback.classic.encoder.PatternLayoutEncoder] for [encoder] propert
    y
    18:36:37,665 |-INFO in ch.qos.logback.classic.joran.action.RootLoggerAction - Setting
level of ROOT logger to INFO
    18:36:37,669 |-INFO in ch.qos.logback.core.joran.action.AppenderRefAction - Attaching
appender named [STDERR] to Logger[ROOT]
    18:36:37,672 |-INFO in ch.qos.logback.classic.joran.action.LoggerAction - Setting level
of logger [h2database] to INFO
    18:36:37,672 |-INFO in ch.qos.logback.classic.joran.action.ConfigurationAction - End of
configuration.
    ```



src/main/resources/logback.xml (line 32)
<https://reviews.apache.org/r/42845/#comment177672>

    I believe you can omit this line, as it will inherit the root logger's appenders.


- Bill Farner


On Jan. 26, 2016, 9:37 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42845/
> -----------------------------------------------------------
> 
> (Updated Jan. 26, 2016, 9:37 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> On a test cluster with DbTaskStore enabled there are several lines in the log that look
like:
> ````
> 2016-01-26 13:07:14 jdbc[15]: exception
> ````
> There is no other information with these lines. This is a result of setting `TRACE_LEVEL_SYSTEM_OUT`
to `1` for H2. This will print out the error message but not the associated throwable: https://github.com/h2database/h2database/blob/a932268843ac84c7a665e427167ff2eb291d6b8e/h2/src/main/org/h2/message/TraceSystem.java#L228
> 
> The SLF4J implementation of tracing in H2 does not suffer from this restriction.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 36c462ac86cc605bd86bfc31c2f962a315099a02

>   src/main/resources/logback.xml faf0dbc94dea536a944be18810a7f330d4c94dee 
> 
> Diff: https://reviews.apache.org/r/42845/diff/
> 
> 
> Testing
> -------
> 
> Set the level to debug initially and observed extra output in Vagrant.
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message