aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From John Sirois <jsir...@apache.org>
Subject Re: Review Request 42748: [1/3] Introduce a thrift java code generator.
Date Wed, 27 Jan 2016 03:58:15 GMT


> On Jan. 25, 2016, 3:28 p.m., John Sirois wrote:
> > NB: Please hold off on review pending an email to dev@ explaining this 3 RB proposal.

Review away, accompanying proposal is now out for review: http://markmail.org/message/a6sdqcelgokw6mwz


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42748/#review116199
-----------------------------------------------------------


On Jan. 25, 2016, 3:28 p.m., John Sirois wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42748/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2016, 3:28 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This generator emits immutable objects and carries over thrift
> annotations to java annotations for both subsequent build-time
> code generation via annotation processors and for runtime use
> in interceptors and other reflective tools.
> 
>  .gitignore                                                                         
                               |   3 +
>  build.gradle                                                                       
                               |  47 ++-
>  buildSrc/build.gradle                                                              
                               |  61 ++++
>  settings.gradle => buildSrc/settings.gradle                                     
                                  |   3 +-
>  buildSrc/thriftGen/src/main/java/org/apache/aurora/thrift/ThriftAnnotation.java    
                               |  45 +++
>  buildSrc/thriftGen/src/main/java/org/apache/aurora/thrift/ThriftAnnotations.java   
                               |  38 +++
>  buildSrc/thriftGen/src/main/java/org/apache/aurora/thrift/ThriftEntity.java        
                               |  70 ++++
>  buildSrc/thriftGen/src/main/java/org/apache/aurora/thrift/ThriftFields.java        
                               |  65 ++++
>  buildSrc/thriftGen/src/main/java/org/apache/aurora/thrift/ThriftService.java       
                               |  43 +++
>  buildSrc/thriftGen/src/main/java/org/apache/aurora/thrift/ThriftStruct.java        
                               |  80 +++++
>  buildSrc/thriftGen/src/main/java/org/apache/aurora/thrift/ThriftUnion.java         
                               |  76 +++++
>  buildSrc/thriftGen/src/main/java/org/apache/aurora/thrift/build/AbstractStructRenderer.java
                       | 132 ++++++++
>  buildSrc/thriftGen/src/main/java/org/apache/aurora/thrift/build/BaseEmitter.java   
                               | 143 +++++++++
>  buildSrc/thriftGen/src/main/java/org/apache/aurora/thrift/build/BaseVisitor.java   
                               | 533 +++++++++++++++++++++++++++++++
>  buildSrc/thriftGen/src/main/java/org/apache/aurora/thrift/build/ConstVisitor.java  
                               |  72 +++++
>  buildSrc/thriftGen/src/main/java/org/apache/aurora/thrift/build/IntegerEnumVisitor.java
                           | 102 ++++++
>  buildSrc/{build.gradle => thriftGen/src/main/java/org/apache/aurora/thrift/build/ParseException.java}
             |  15 +-
>  buildSrc/thriftGen/src/main/java/org/apache/aurora/thrift/build/ServiceVisitor.java
                               | 279 ++++++++++++++++
>  buildSrc/thriftGen/src/main/java/org/apache/aurora/thrift/build/StructVisitor.java 
                               | 619 +++++++++++++++++++++++++++++++++++
>  buildSrc/thriftGen/src/main/java/org/apache/aurora/thrift/build/SymbolTable.java   
                               | 180 +++++++++++
>  buildSrc/thriftGen/src/main/java/org/apache/aurora/thrift/build/ThriftGen.java     
                               | 190 +++++++++++
>  buildSrc/thriftGen/src/main/java/org/apache/aurora/thrift/build/ThriftGenVisitor.java
                             | 122 +++++++
>  buildSrc/{build.gradle => thriftGen/src/main/java/org/apache/aurora/thrift/build/UnexpectedTypeException.java}
    |  13 +-
>  buildSrc/thriftGen/src/main/java/org/apache/aurora/thrift/build/UnionVisitor.java  
                               | 254 +++++++++++++++
>  buildSrc/{build.gradle => thriftGen/src/main/java/org/apache/aurora/thrift/build/UnsupportedFeatureException.java}
|  12 +-
>  buildSrc/thriftGen/src/main/java/org/apache/aurora/thrift/build/Visitor.java       
                               |  95 ++++++
>  buildSrc/thriftGen/src/test/java/org/apache/aurora/thrift/build/ThriftGenTest.java 
                               | 869 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  settings.gradle                                                                    
                               |   2 +-
>  28 files changed, 4127 insertions(+), 36 deletions(-)
> 
> 
> Diffs
> -----
> 
>   .gitignore 1af09a251b3f76c13813033d32aa7efba9aef304 
>   build.gradle 5b9e0152bfe3fe1f304fa839cfc4cec646819c2e 
>   buildSrc/build.gradle e3d6debf1959ec2c50970c317b59a04a2d9c1f82 
>   buildSrc/settings.gradle PRE-CREATION 
>   buildSrc/thriftGen/src/main/java/org/apache/aurora/thrift/ThriftAnnotation.java PRE-CREATION

>   buildSrc/thriftGen/src/main/java/org/apache/aurora/thrift/ThriftAnnotations.java PRE-CREATION

>   buildSrc/thriftGen/src/main/java/org/apache/aurora/thrift/ThriftEntity.java PRE-CREATION

>   buildSrc/thriftGen/src/main/java/org/apache/aurora/thrift/ThriftFields.java PRE-CREATION

>   buildSrc/thriftGen/src/main/java/org/apache/aurora/thrift/ThriftService.java PRE-CREATION

>   buildSrc/thriftGen/src/main/java/org/apache/aurora/thrift/ThriftStruct.java PRE-CREATION

>   buildSrc/thriftGen/src/main/java/org/apache/aurora/thrift/ThriftUnion.java PRE-CREATION

>   buildSrc/thriftGen/src/main/java/org/apache/aurora/thrift/build/AbstractStructRenderer.java
PRE-CREATION 
>   buildSrc/thriftGen/src/main/java/org/apache/aurora/thrift/build/BaseEmitter.java PRE-CREATION

>   buildSrc/thriftGen/src/main/java/org/apache/aurora/thrift/build/BaseVisitor.java PRE-CREATION

>   buildSrc/thriftGen/src/main/java/org/apache/aurora/thrift/build/ConstVisitor.java PRE-CREATION

>   buildSrc/thriftGen/src/main/java/org/apache/aurora/thrift/build/IntegerEnumVisitor.java
PRE-CREATION 
>   buildSrc/thriftGen/src/main/java/org/apache/aurora/thrift/build/ParseException.java
PRE-CREATION 
>   buildSrc/thriftGen/src/main/java/org/apache/aurora/thrift/build/ServiceVisitor.java
PRE-CREATION 
>   buildSrc/thriftGen/src/main/java/org/apache/aurora/thrift/build/StructVisitor.java
PRE-CREATION 
>   buildSrc/thriftGen/src/main/java/org/apache/aurora/thrift/build/SymbolTable.java PRE-CREATION

>   buildSrc/thriftGen/src/main/java/org/apache/aurora/thrift/build/ThriftGen.java PRE-CREATION

>   buildSrc/thriftGen/src/main/java/org/apache/aurora/thrift/build/ThriftGenVisitor.java
PRE-CREATION 
>   buildSrc/thriftGen/src/main/java/org/apache/aurora/thrift/build/UnexpectedTypeException.java
PRE-CREATION 
>   buildSrc/thriftGen/src/main/java/org/apache/aurora/thrift/build/UnionVisitor.java PRE-CREATION

>   buildSrc/thriftGen/src/main/java/org/apache/aurora/thrift/build/UnsupportedFeatureException.java
PRE-CREATION 
>   buildSrc/thriftGen/src/main/java/org/apache/aurora/thrift/build/Visitor.java PRE-CREATION

>   buildSrc/thriftGen/src/test/java/org/apache/aurora/thrift/build/ThriftGenTest.java
PRE-CREATION 
>   settings.gradle b097e2fd958fa0ce6076fc104eb3890c4029295d 
> 
> Diff: https://reviews.apache.org/r/42748/diff/
> 
> 
> Testing
> -------
> 
> Locally green: `./gradlew -Pq test`
> 
> 
> Thanks,
> 
> John Sirois
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message