aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From John Sirois <jsir...@apache.org>
Subject Re: Review Request 42816: Remove deprecated `HealthCheckConfig` fields.
Date Tue, 26 Jan 2016 19:53:21 GMT


> On Jan. 26, 2016, 12:24 p.m., Dmitriy Shirchenko wrote:
> > src/test/python/apache/aurora/client/test_config.py, lines 213-223
> > <https://reviews.apache.org/r/42816/diff/1/?file=1221724#file1221724line213>
> >
> >     this test is still relevant though, no? you still need to validate that only
one type was specified and make sure we don't default to one w/out giving feedback to the
user. this is expected to be a pystachio error.
> 
> John Sirois wrote:
>     Well - the check is just a type-check, which pystachio already does for all fields,
ie - can't pass 1 to a String field, etc.  So it seemed like a test of pystachio at this point,
which does not belong here.
> 
> John Sirois wrote:
>     Re-reading your comment though, a check that `HealthCheckerConfig` has exactly one
of its fields (`http` or `shell`) populated might be a worthwhile check.  That said - the
check did not exist in this file before afaict.
>     I'll re-open the issue pending your response.
> 
> John Sirois wrote:
>     OK - dropping the issue given your ship, but this does seem like a pre-existing bug
or else missing feature; ie failing if both `http` and `shell` are set since only 1 - `shell`
will be used in this case.
>     In other words, what we ideally want for `HealthCheckerConfig` is a single union
field (if pystachio supported `Union(A, B, ... Z)`), or - better - `Job.health_check_config`
defined as a union field.
>     If I've described this correctly I'll open a seperate issue for a seperate release
that adds that sort of check one way or the other.
> 
> Dmitriy Shirchenko wrote:
>     Yea, I tried writing one but it got complicated with two ways of defining http based
health check. It will be more straightforward to write one now. I think it's worthwhile to
add more safeguards, being someone who makes a lot of config mistakes.

OK - filed https://issues.apache.org/jira/browse/AURORA-1599 for that.


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42816/#review116419
-----------------------------------------------------------


On Jan. 26, 2016, 12:26 p.m., John Sirois wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42816/
> -----------------------------------------------------------
> 
> (Updated Jan. 26, 2016, 12:26 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Maxim Khutornenko, Dmitriy Shirchenko, and Bill
Farner.
> 
> 
> Bugs: AURORA-1552 and AURORA-1563
>     https://issues.apache.org/jira/browse/AURORA-1552
>     https://issues.apache.org/jira/browse/AURORA-1563
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Remove `endpoint`, `expected_response` and `expected_response_code`
> which were all deprecated in Aurora 0.11.0 in favor of the same-named
> fields in `HttpHealthChecker`.
> 
> This also removes health check validation in the client in favor of
> leveraging the pystachio schema.  The one difference this allows for is
> an empty string for the `ShellHealthChecker.shell_command`.  Since an
> empty string is a valid shell command (equivalent to `true`), this
> simplification seems justified.
> 
>  NEWS                                                            |  3 ++
>  docs/configuration-reference.md                                 |  3 --
>  src/main/python/apache/aurora/client/config.py                  | 31 ------------------
>  src/main/python/apache/aurora/config/schema/base.py             |  5 +--
>  src/main/python/apache/aurora/executor/common/health_checker.py | 17 +++-------
>  src/test/python/apache/aurora/client/test_config.py             | 88 --------------------------------------------------
>  6 files changed, 9 insertions(+), 138 deletions(-)
> 
> 
> Diffs
> -----
> 
>   NEWS 3f40aba46dc72b50607c82a2cc89040b1d10048a 
>   docs/configuration-reference.md c04f3b7c927ff44c26b38ce38a65041c24a68e81 
>   src/main/python/apache/aurora/client/config.py a4fa48533b8266dd8e87eb830677f200e7e3cbb2

>   src/main/python/apache/aurora/config/schema/base.py 0e4dfc220bbecc5f679b067833dffc253c912d85

>   src/main/python/apache/aurora/executor/common/health_checker.py 01194aa47d31ac058b89bce8662cec58856dc5f4

>   src/test/python/apache/aurora/client/test_config.py de0973d7901301433c3d9dca7bac8555a74604c9

> 
> Diff: https://reviews.apache.org/r/42816/diff/
> 
> 
> Testing
> -------
> 
> Locally green:
> ```
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ```
> 
> 
> Thanks,
> 
> John Sirois
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message