aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aurora ReviewBot <wfar...@apache.org>
Subject Re: Review Request 42811: Remove deprecated fields made redundant by JobKey.
Date Tue, 26 Jan 2016 18:59:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42811/#review116409
-----------------------------------------------------------



This patch does not apply cleanly against master (7ccd532), do you need to rebase?

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Jan. 26, 2016, 6:37 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42811/
> -----------------------------------------------------------
> 
> (Updated Jan. 26, 2016, 6:37 p.m.)
> 
> 
> Review request for Aurora, John Sirois and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1598
>     https://issues.apache.org/jira/browse/AURORA-1598
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Despite the previous effort to decouple from these fields in advance, this patch is still
pretty big.  I could have broken this one up, but i think it's better as an atom in case revert
becomes necessary.
> 
> 
> Diffs
> -----
> 
>   NEWS f2798f6a2d6841606e99a93677067e58dc5cf5cc 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift a93df2165c208c4963975aeb4f174df602baa476

>   src/main/java/org/apache/aurora/scheduler/base/Query.java 7bf0afb5c4d53942cb11b7e405196c94590bd75c

>   src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 02ba1e3099ea5e1c4422e5b663b937365e1deb22

>   src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java e4dbf06f41dddcbfb14521f8ceb9406b967713ee

>   src/main/java/org/apache/aurora/scheduler/storage/db/views/DbTaskConfig.java 16f2cb143469974efe4dc191c13788d8b8e21c57

>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 662cae179142b34896b11275bd3b425903f22e3e

>   src/main/python/apache/aurora/admin/admin.py b68f546b5710b373ffd1fc25b2d2096cc1b9981d

>   src/main/python/apache/aurora/client/api/sla.py 5855685bda7188c55432dc6f1ad3c676a38309da

>   src/main/python/apache/aurora/client/cli/jobs.py deba3a9026384e5bd436e611ab5b5ae3afc1cfcc

>   src/main/python/apache/aurora/client/cli/task.py b722cd808c1bd0eaaa233a93381685d0e511e742

>   src/main/python/apache/aurora/config/thrift.py b40a7fdfa63eaf18d9a85f62eec5aa717a7e7d91

>   src/main/python/apache/aurora/executor/common/announcer.py c89cf4caa0df1a26a0839d7ef1b2b6f2e0ee0c82

>   src/main/python/apache/aurora/executor/common/sandbox.py d4c366e5deba1b03d1727dcc06e41661fff6c2ee

>   src/main/resources/org/apache/aurora/scheduler/storage/db/CronJobMapper.xml ee603f42ce58e2cc73e4648f0c2f084d338c235b

>   src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml 4e8966dc29689573a5ee3ba4c29392c3a7d14208

>   src/main/resources/org/apache/aurora/scheduler/storage/db/TaskMapper.xml db6c642522c422946eb3933859a2c3415e684cfe

>   src/main/resources/scheduler/assets/js/controllers.js dff6645ea030500fb82baa68f0d971503ada1bce

>   src/main/resources/scheduler/assets/js/services.js f9e8580d2db7b5418e8a89c8547a65a523c1a009

>   src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
317506eb01457f8eee013fed40f16895369c660f 
>   src/test/java/org/apache/aurora/scheduler/cron/quartz/CronIT.java 3ce78e355368acb539cd374638be665535bbfd4a

>   src/test/java/org/apache/aurora/scheduler/cron/quartz/QuartzTestUtil.java ef9aae11a9fcecf099241817528dbf2213515802

>   src/test/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilterTest.java
ef20641b056a38d3f816acf476dd3e6f12f22ce0 
>   src/test/java/org/apache/aurora/scheduler/storage/AbstractCronJobStoreTest.java 22a6b43c97f6b0d2294d9cda218cf2889838f1c9

>   src/test/java/org/apache/aurora/scheduler/storage/log/LogManagerTest.java 0443bb3ad7350bc442463fd1d4c0b51ddb38301e

>   src/test/java/org/apache/aurora/scheduler/thrift/Fixtures.java 72d21829239f771a9df192b417147d871521d24f

>   src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java 0428c779eabd16fe88ee1e41150cc76e3731fe8d

>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
b9ce2ddba051ab2baed59108d70537d84a031934 
>   src/test/java/org/apache/aurora/scheduler/updater/JobDiffTest.java 67fe14b2fa90f9577b8ccab1e2c7b9e8a82e74b6

>   src/test/python/apache/aurora/admin/test_admin.py e8da335c2d98d3338b48357c4eeac328e30f9d1a

>   src/test/python/apache/aurora/client/api/test_api.py 59f34a58ce083d9e2bdf125a8baaf511ca6d3901

>   src/test/python/apache/aurora/client/api/test_sla.py 674e7f8c9d5b327945a05ea1dd54c83e0b9ff78d

>   src/test/python/apache/aurora/client/cli/test_status.py a75f15e99af97acb0af7e112e28c693a77f9eb24

>   src/test/python/apache/aurora/client/cli/util.py c7aa5cc5a5ea1da01fa75d4d22ff1256e27521b7

>   src/test/python/apache/aurora/config/test_thrift.py 1bd745964b45b30014cabbef89949ac6221f148b

>   src/test/python/apache/aurora/executor/common/test_announcer.py bb9e4b0bca40270b719eb47fd9d8f4ec8aabb665

>   src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py
c473808d3df6cfd44c3515f2b6dcf20b0efa1075 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 32e8b9bad4803b2196716cbc6710366a8a8c01a3

> 
> Diff: https://reviews.apache.org/r/42811/diff/
> 
> 
> Testing
> -------
> 
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message