aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zameer Manji <zma...@apache.org>
Subject Re: Review Request 42668: Remove most direct uses of deprecated TaskConfig fields.
Date Fri, 22 Jan 2016 23:30:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42668/#review115954
-----------------------------------------------------------


Ship it!




Ship It!

- Zameer Manji


On Jan. 22, 2016, 11:23 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42668/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2016, 11:23 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> After https://reviews.apache.org/r/42646/, i ventured towards removing TaskConfig fields
that have been marked as deprecated:
> 
> TaskConfig.owner.role
> TaskConfig.environment
> TaskConfig.jobName
> 
> Turns out we still cannot remove them, but i resolved to at least prepare a lot of our
code for the removal.  The majority of the work here was converting unit tests to use `TaskTestUtil`.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/http/Utilization.java 440946bf6cb9dac21b64acdca3678b505ef37aff

>   src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 37700569c5b8d14dcc7f29ac564cb6546f73ea34

>   src/main/java/org/apache/aurora/scheduler/storage/TaskStore.java 4e4f8d2c0f237c4480abe101835176f7d69958db

>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 69eab90fa053c917a6a2c60b548802ba450fa80c

>   src/test/java/org/apache/aurora/codec/ThriftBinaryCodecTest.java ebb4f9a20e382360032bfad3389349ef13117460

>   src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java 0a9dfe31b7680d92e8101abfad4e88a324f37a77

>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 9fb8aad5d1c0412efc6d1176e543321ebe503e03

>   src/test/java/org/apache/aurora/scheduler/cron/quartz/QuartzTestUtil.java f0624976259762cc2c86a653e27e9e5ea1bc71f0

>   src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java 3b1766d67e5bfcb5b5d1bd1759d251b7f1732e9d

>   src/test/java/org/apache/aurora/scheduler/http/api/ApiBetaTest.java 2b5a82db77827013f86880d497cde3758276878a

>   src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 066c6a3393955ca4dc67e5ddfc6ead9b451b9b4e

>   src/test/java/org/apache/aurora/scheduler/pruning/TaskHistoryPrunerTest.java e1b539136fde48b95ab9f00d31b0e5674e27d37d

>   src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 920e3e594330ed87c69c2cbf65607621478685b4

>   src/test/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculatorImplTest.java
9d21dcd47995d9955c3b4ecfb1a7c1f863022d81 
>   src/test/java/org/apache/aurora/scheduler/sla/MetricCalculatorTest.java 89162d12aee13bd70f340df9ea64eb86e555f8d3

>   src/test/java/org/apache/aurora/scheduler/sla/SlaTestUtil.java 7fb6278d75561c2d38fd7a92b168563d20e8c1d9

>   src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java 4a655f10b96b91e48b465a10569bbbc7a62c412f

>   src/test/java/org/apache/aurora/scheduler/state/MaintenanceControllerImplTest.java
092df8cdb7901e045682d0f252109a08afc50c01 
>   src/test/java/org/apache/aurora/scheduler/state/TaskStateMachineTest.java d0a6cd6e48d6d5623b4b7a68f9e6d5336c61bbe7

>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
d12b56eb675e5187fb375a27ace3849fdab1dd8d 
>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdateEventSubscriberTest.java
fffbc36d034525e012fd19e95e91fd5bae152c5d 
> 
> Diff: https://reviews.apache.org/r/42668/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message