aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Sirois" <jsir...@apache.org>
Subject Re: Review Request 42332: Turn TaskHistoryPruner into a service and trigger shutdown on pruning failure.
Date Fri, 22 Jan 2016 02:48:29 GMT


> On Jan. 21, 2016, 4:20 p.m., John Sirois wrote:
> > src/main/java/org/apache/aurora/scheduler/pruning/TaskHistoryPruner.java, line 164
> > <https://reviews.apache.org/r/42332/diff/3-5/?file=1203998#file1203998line164>
> >
> >     I was envisioning put and take, no schedules, no batching. The queue could even
be a SynchronousQueue holding ~0 elements. Any reason not to simplify in that way?
> 
> Zameer Manji wrote:
>     The documentation for Guava's `AbstractExecutionThreadService` says: "You must override
the run() method, and it must respond to stop requests.". If we just implemented `take`, the
thread of the service would block for a long time if there was no TaskStateChanges, possibly
causing this service to not respond to stop requests. I don't know what the implications are
of not responding to stop requests, but I would like to avoid that case.
>     
>     I decided that it would be easier to just use `AbstractScheduledService` instead
and avoid this case.
> 
> John Sirois wrote:
>     OK - I may follow up with a proposal RB on my own time - I think this can be simpler
and clearer, but I need to sketch some to see if I'm lying.

See what you think of this: https://reviews.apache.org/r/42639/


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42332/#review115730
-----------------------------------------------------------


On Jan. 21, 2016, 4:43 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42332/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2016, 4:43 p.m.)
> 
> 
> Review request for Aurora, John Sirois and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1582
>     https://issues.apache.org/jira/browse/AURORA-1582
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Task pruning is key to operating a large cluster and failure to prune should trigger
shutdown to prevent unbounded growth of storage. This patch turns `TaskHistoryPruner` into
a service which propagates failure from failed pruning attempts towards the `ServiceManager`.
Also completing a TODO which removes a test for behaviour that is very awkward to test for.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/pruning/PruningModule.java 735199ac1ccccab343c24471890aa330d6635c26

>   src/main/java/org/apache/aurora/scheduler/pruning/TaskHistoryPruner.java 2064089937f5178b1413d386a312f4173a0e35fb

>   src/test/java/org/apache/aurora/scheduler/pruning/TaskHistoryPrunerTest.java 295960f13693c6ba0d7075a8ef7f9680a91ae69d

> 
> Diff: https://reviews.apache.org/r/42332/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build -Pq
> e2e tests
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message