aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zameer Manji" <zma...@apache.org>
Subject Re: Review Request 42332: Turn TaskHistoryPruner into a service and trigger shutdown on pruning failure.
Date Thu, 21 Jan 2016 22:54:40 GMT


> On Jan. 21, 2016, 2:50 p.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/pruning/TaskHistoryPruner.java, line 108
> > <https://reviews.apache.org/r/42332/diff/4/?file=1204701#file1204701line108>
> >
> >     Why BlockingQueue and not something like ConcurrentLinkedQueue? There is nothing
to block here for.

`BlockingQueue` has the `drainTo` method which I think makes the iteration nicer.


> On Jan. 21, 2016, 2:50 p.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/pruning/TaskHistoryPruner.java, line 140
> > <https://reviews.apache.org/r/42332/diff/4/?file=1204701#file1204701line140>
> >
> >     runOneIteration() implies periodicity already, consider simplifying this comment

Simplified.


> On Jan. 21, 2016, 2:50 p.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/pruning/TaskHistoryPruner.java, line 153
> > <https://reviews.apache.org/r/42332/diff/4/?file=1204701#file1204701line153>
> >
> >     Does it have to run every second? This just checks for errors so a higher limit
should suffice (e.g. 5 seconds).

No, it does not have to run every second. Changed it to every 5 seconds.


- Zameer


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42332/#review115720
-----------------------------------------------------------


On Jan. 21, 2016, 2:22 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42332/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2016, 2:22 p.m.)
> 
> 
> Review request for Aurora, John Sirois and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1582
>     https://issues.apache.org/jira/browse/AURORA-1582
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Task pruning is key to operating a large cluster and failure to prune should trigger
shutdown to prevent unbounded growth of storage. This patch turns `TaskHistoryPruner` into
a service which propagates failure from failed pruning attempts towards the `ServiceManager`.
Also completing a TODO which removes a test for behaviour that is very awkward to test for.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/pruning/PruningModule.java 735199ac1ccccab343c24471890aa330d6635c26

>   src/main/java/org/apache/aurora/scheduler/pruning/TaskHistoryPruner.java 2064089937f5178b1413d386a312f4173a0e35fb

>   src/test/java/org/apache/aurora/scheduler/pruning/TaskHistoryPrunerTest.java 295960f13693c6ba0d7075a8ef7f9680a91ae69d

> 
> Diff: https://reviews.apache.org/r/42332/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build -Pq
> e2e tests
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message