aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 42387: working version of jessie builds
Date Thu, 21 Jan 2016 01:26:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42387/#review115532
-----------------------------------------------------------


Mostly questions for posterity.


build-artifact.sh (line 35)
<https://reviews.apache.org/r/42387/#comment176506>

    How about a selective `set -x`, `set +x` around the commands you wish to see echoed instead?



builder/deb/debian-jessie/Dockerfile (line 37)
<https://reviews.apache.org/r/42387/#comment176507>

    FYI - the deb has a build-time dep of a package named 'gradle', so it would be slightly
more involved than that.



builder/deb/debian-jessie/build.sh (line 1)
<https://reviews.apache.org/r/42387/#comment176508>

    Checking my recollection - this can't be a symlink due to the way it's mounted with docker,
right?  If that's correct, can you leave a TODO for me to figure out how to share these files?



specs/debian/aurora-executor.thermos.init (lines 43 - 44)
<https://reviews.apache.org/r/42387/#comment176510>

    Is this necessary due to `app_daemonize` or is there more to it?


- Bill Farner


On Jan. 19, 2016, 4:59 p.m., Dmitriy Shirchenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42387/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2016, 4:59 p.m.)
> 
> 
> Review request for Aurora, Benjamin Staffin, John Sirois, and Bill Farner.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> -------
> 
> Adding debian jessie packaging with a test.
> 
> 
> Diffs
> -----
> 
>   build-artifact.sh 333c7a4d8e661f608c4949dcbae1401bb1a75b51 
>   builder/deb/debian-jessie/Dockerfile PRE-CREATION 
>   builder/deb/debian-jessie/build.sh PRE-CREATION 
>   builder/deb/debian-jessie/pants.ini PRE-CREATION 
>   specs/debian/aurora-executor.thermos.init e5c940147f5f0a1842d15be9bb9c44e838bc9af0

>   specs/debian/aurora-executor.thermos.service PRE-CREATION 
>   specs/debian/aurora-scheduler.init 59b200fcd9029e14ea63fe8edb159022e7bde346 
>   specs/debian/aurora-scheduler.service PRE-CREATION 
>   specs/debian/aurora-scheduler.upstart 1ceb7042485efedcf7136b51737107aada4c4e96 
>   specs/rpm/SOURCES/aurora.sysconfig f421d19db007960764054ea10b5fc3d3478f2a15 
>   test/deb/debian-jessie/README.md PRE-CREATION 
>   test/deb/debian-jessie/Vagrantfile PRE-CREATION 
>   test/deb/debian-jessie/provision.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/42387/diff/
> 
> 
> Testing
> -------
> 
> New build with a test that starts a Vagrant and following README should lead to a successful
job.
> 
> 
> Thanks,
> 
> Dmitriy Shirchenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message