aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 42565: Remove support for adding guice modules via command line arguments.
Date Wed, 20 Jan 2016 20:20:25 GMT


> On Jan. 20, 2016, 12:02 p.m., John Sirois wrote:
> > src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java,
line 81
> > <https://reviews.apache.org/r/42565/diff/2/?file=1203724#file1203724line81>
> >
> >     So if I installed a single custom Module in the past, ie: `-shiro_real_modules=com.example.Foo`,
I now do `-shiro_real_modules=''` and erect a custom main that calls:
> >     ```java
> >     applyStaticArgumentValues(args);
> >     publicMain(new com.exampleFoo());
> >     ```
> >     
> >     My module shiro module is still installed, but as a normal extra module, not
by `HttpSecurityModule` - which now installs 0 `RealmModule`s.

That's correct.


> On Jan. 20, 2016, 12:02 p.m., John Sirois wrote:
> > src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java,
line 87
> > <https://reviews.apache.org/r/42565/diff/2/?file=1203724#file1203724line87>
> >
> >     I'm not sure this is exactly true, Kerberos5ShiroRealmModule will need to be
hand constructed with its params bean or else guice injected with it; both of which, if sticking
with an enum, will require a lazy approach.  In short - not sure this second sentence should
stay.

You're right.  I wasn't sure how to word it without directly describing the forthcoming args
API...but i will just omit the sentence.  Revisiting this will be forced by the args change
anyhow.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42565/#review115469
-----------------------------------------------------------


On Jan. 20, 2016, 11:47 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42565/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2016, 11:47 a.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This patch proposes that users installing custom modules do so via a custom main.
> 
> Specifying custom modules on the command line has proven troublesome for replacing the
command line args system with one where all arguments are injected and explicitly-defined.
 It also adds complexity to the scheduler application by unnecessarily punching holes at specific
places.
> 
> If this proposal is agreeable, i will add a NEWS entry and document how one might implement
a custom main to add modules.  The tl;dr, however, is to invoke `SchedulerMain.publicMain(customModule)`
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/app/MoreModules.java d5f96543d1068bf30b9d173a247c2806faf35578

>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 0659c358479283756179c2cabebc8416730cc3e3

>   src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java
e32862034a1ad47dae8fff89cb04deb34ccd90e2 
>   src/main/java/org/apache/aurora/scheduler/http/api/security/ModuleParser.java ccd9a20e8b18831458cba2d53e6b8b84fef06162

>   src/test/java/org/apache/aurora/scheduler/app/MoreModulesTest.java b2fb3c9dcba64f69a05894f506ba43766f74ddaa

>   src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java 3e811a4f4d2c82892217ca1f950ac792303fbcf3

>   src/test/java/org/apache/aurora/scheduler/http/api/security/ModuleParserTest.java baaeb2390a909de1a92e4328d35a49f7b74c36cb

> 
> Diff: https://reviews.apache.org/r/42565/diff/
> 
> 
> Testing
> -------
> 
> end-to-end tests, `./gradlew run`
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message