aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmitriy Shirchenko" <cald...@gmail.com>
Subject Re: Review Request 42387: working version of jessie builds
Date Wed, 20 Jan 2016 00:59:51 GMT


> On Jan. 20, 2016, 12:12 a.m., John Sirois wrote:
> > specs/debian/aurora-scheduler.postinst, line 38
> > <https://reviews.apache.org/r/42387/diff/2/?file=1202247#file1202247line38>
> >
> >     `specs/debian/aurora-scheduler.init` uses `PIDFILE=/var/run/aurora-scheduler.pid`
- who uses `/var/run/aurora/`?

Done.


> On Jan. 20, 2016, 12:12 a.m., John Sirois wrote:
> > specs/debian/aurora-executor.thermos.init, line 54
> > <https://reviews.apache.org/r/42387/diff/1-2/?file=1199232#file1199232line54>
> >
> >     Not sure the with $ARGS makes much sense for stop, it might even be a lie when
stopping an older deploy.

Done.


> On Jan. 20, 2016, 12:12 a.m., John Sirois wrote:
> > builder/deb/debian-jessie/Dockerfile, line 38
> > <https://reviews.apache.org/r/42387/diff/2/?file=1202241#file1202241line38>
> >
> >     Its not exactly clear to me how this is any better than downloading gradle from
gradle.  Since this is only used for the builder it seems to me the only relevant details
is - not a standard package install - aka a ~random internet download.  If the plan is that
benley's work here makes it upstream to a standard debian deb repo I think its worth a comment
pointing that expected future out.  As it stands w/o that comment and forgetting we know and
trust benley, this looks on the face decidedly worse than going straight to the gradle source.

Done.


> On Jan. 20, 2016, 12:12 a.m., John Sirois wrote:
> > specs/debian/aurora-executor.thermos.init, line 22
> > <https://reviews.apache.org/r/42387/diff/2/?file=1202244#file1202244line22>
> >
> >     This is admittedly all over the place across our packages and OSs already before
your change, but for the deb scheduler we have `/var/run/aurora-scheduler.pid` - how about
`/var/run/aurora-observer.pid` or `/var/run/thermos-observer.pid`, some consistency here would
be useful I think for discovery purposes.

Done.


- Dmitriy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42387/#review115281
-----------------------------------------------------------


On Jan. 20, 2016, 12:59 a.m., Dmitriy Shirchenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42387/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2016, 12:59 a.m.)
> 
> 
> Review request for Aurora, Benjamin Staffin, John Sirois, and Bill Farner.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> -------
> 
> Adding debian jessie packaging with a test.
> 
> 
> Diffs
> -----
> 
>   build-artifact.sh 333c7a4d8e661f608c4949dcbae1401bb1a75b51 
>   builder/deb/debian-jessie/Dockerfile PRE-CREATION 
>   builder/deb/debian-jessie/build.sh PRE-CREATION 
>   builder/deb/debian-jessie/pants.ini PRE-CREATION 
>   specs/debian/aurora-executor.thermos.init e5c940147f5f0a1842d15be9bb9c44e838bc9af0

>   specs/debian/aurora-executor.thermos.service PRE-CREATION 
>   specs/debian/aurora-scheduler.init 59b200fcd9029e14ea63fe8edb159022e7bde346 
>   specs/debian/aurora-scheduler.service PRE-CREATION 
>   specs/debian/aurora-scheduler.upstart 1ceb7042485efedcf7136b51737107aada4c4e96 
>   specs/rpm/SOURCES/aurora.sysconfig f421d19db007960764054ea10b5fc3d3478f2a15 
>   test/deb/debian-jessie/README.md PRE-CREATION 
>   test/deb/debian-jessie/Vagrantfile PRE-CREATION 
>   test/deb/debian-jessie/provision.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/42387/diff/
> 
> 
> Testing
> -------
> 
> New build with a test that starts a Vagrant and following README should lead to a successful
job.
> 
> 
> Thanks,
> 
> Dmitriy Shirchenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message