aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 42177: Vagrant change to reserve part of the dev cluster's resources to 'aurora-role'
Date Tue, 19 Jan 2016 18:48:20 GMT


> On Jan. 19, 2016, 6:39 p.m., Maxim Khutornenko wrote:
> > examples/vagrant/upstart/mesos-master.conf, line 27
> > <https://reviews.apache.org/r/42177/diff/1/?file=1192902#file1192902line27>
> >
> >     Is this really needed? All logs are currently dumped under /var/log/upstart
if I remember it right.
> 
> Zhitao Li wrote:
>     You are indeed right. I added this before findout out Mesos logs is in the other
location. I'll rebase this review request and remove this log line change.
>     
>     This review mostly exists to show how I performed integration tests when working
on previous diff. If anyone feels that we do not want to change the default mode of integration
test, I don't feel strong to check this in anyway.
> 
> Bill Farner wrote:
>     I'm a big proponent of having this covered in the integration tests, so I'm happy
to see this patch.

+1.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42177/#review115204
-----------------------------------------------------------


On Jan. 19, 2016, 6:46 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42177/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2016, 6:46 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko, Dmitriy Shirchenko, and Bill Farner.
> 
> 
> Bugs: AURORA-1109
>     https://issues.apache.org/jira/browse/AURORA-1109
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This is how I tested changes in https://reviews.apache.org/r/42176/.
> 
> 
> Diffs
> -----
> 
>   examples/vagrant/upstart/aurora-scheduler.conf 8120ff7706f0ad0810ec9018c55d0d065066cbc5

>   examples/vagrant/upstart/mesos-master.conf 9d7491c08e14e3951b2fd2f74291a2009883c379

>   examples/vagrant/upstart/mesos-slave.conf 1ef059b17d16d4f1594a19ff6422ea653a413359

> 
> Diff: https://reviews.apache.org/r/42177/diff/
> 
> 
> Testing
> -------
> 
> Integration test script.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message