aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aurora ReviewBot" <wfar...@apache.org>
Subject Re: Review Request 42375: Make required mesos log args required.
Date Sat, 16 Jan 2016 04:27:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42375/#review114840
-----------------------------------------------------------


Master (b563679) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Jan. 16, 2016, 3:41 a.m., John Sirois wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42375/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2016, 3:41 a.m.)
> 
> 
> Review request for Aurora, Dmitriy Shirchenko and Zameer Manji.
> 
> 
> Bugs: AURORA-1587
>     https://issues.apache.org/jira/browse/AURORA-1587
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Both -native_log_file_path and -native_log_zk_group_path are required
> but they were not validated (-native_log_file_path) and validated too
> late in a provider (-native_log_zk_group_path) to provide useful
> failure messages.  Correct this and make the arguments required in
> the arg parsing phase.
> 
>  src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java 906b3494ab35e70397927ec13f3d9a814059575c

> 
> Diff: https://reviews.apache.org/r/42375/diff/
> 
> 
> Testing
> -------
> 
> ```
> ./gradlew clean distZip
> unzip -qd /tmp/ dist/distributions/aurora-scheduler-0.12.0-SNAPSHOT.zip
> /tmp/aurora-scheduler-0.12.0-SNAPSHOT/bin/aurora-scheduler \
>   -mesos_master_address=localhost:5050 \
>   -backup_dir=/tmp \
>   -serverset_path=/aurora \
>   -cluster_name=test -zk_endpoints=localhost:2181
> ...
> I0115 20:18:37.890 [main, ArgScanner:443] zk_in_proc (org.apache.aurora.scheduler.zookeeper.guice.client.flagged.FlaggedClientConfig.zk_in_proc):
false 
> I0115 20:18:37.890 [main, ArgScanner:443] zk_session_timeout (org.apache.aurora.scheduler.zookeeper.guice.client.flagged.FlaggedClientConfig.zk_session_timeout):
(4, secs) 
> I0115 20:18:37.890 [main, ArgScanner:445] -------------------------------------------------------------------------

> Exception in thread "main" java.lang.IllegalStateException: A value for the -native_log_file_path
flag must be supplied
> 	at org.apache.aurora.scheduler.log.mesos.MesosLogStreamModule.getRequiredArg(MesosLogStreamModule.java:99)
> 	at org.apache.aurora.scheduler.log.mesos.MesosLogStreamModule.<init>(MesosLogStreamModule.java:110)
> 	at org.apache.aurora.scheduler.app.SchedulerMain.main(SchedulerMain.java:209)
> ```
> 
> 
> Thanks,
> 
> John Sirois
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message