aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Sirois" <jsir...@apache.org>
Subject Review Request 42375: Make required mesos log args required.
Date Sat, 16 Jan 2016 00:40:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42375/
-----------------------------------------------------------

Review request for Aurora, Dmitriy Shirchenko and Zameer Manji.


Bugs: AURORA-1587
    https://issues.apache.org/jira/browse/AURORA-1587


Repository: aurora


Description
-------

Both -native_log_file_path and -native_log_zk_group_path are required
but they were not validated (-native_log_file_path) and validated too
late in a provider (-native_log_zk_group_path) to provide useful
failure messages.  Correct this and make the arguments required in
the arg parsing phase.

 src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)


Diffs
-----

  src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java 906b3494ab35e70397927ec13f3d9a814059575c


Diff: https://reviews.apache.org/r/42375/diff/


Testing
-------

```
./gradlew clean distZip
unzip -qd /tmp/ dist/distributions/aurora-scheduler-0.12.0-SNAPSHOT.zip
/tmp/aurora-scheduler-0.12.0-SNAPSHOT/bin/aurora-scheduler
...
-zk_session_timeout=(4, secs)
	The ZooKeeper session timeout.
	(org.apache.aurora.scheduler.zookeeper.guice.client.flagged.FlaggedClientConfig.zk_session_timeout)
-------------------------------------------------------------------------
E0115 17:39:48.671 [main, SchedulerMain:217] Failed to apply arguments
java.lang.IllegalArgumentException: Value did not meet constraints:
	native_log_zk_group_path - Value must not be null.
	mesos_master_address - Value must not be null.
	backup_dir - Value must not be null.
	serverset_path - Value must not be null.
	cluster_name - Value must not be null.
	native_log_file_path - Value must not be null.
 java.lang.IllegalArgumentException: Value did not meet constraints:
	native_log_zk_group_path - Value must not be null.
	mesos_master_address - Value must not be null.
	backup_dir - Value must not be null.
	serverset_path - Value must not be null.
	cluster_name - Value must not be null.
	native_log_file_path - Value must not be null.

	at org.apache.aurora.common.args.ArgScanner.process(ArgScanner.java:437) ~[commons-0.12.0-SNAPSHOT.jar:na]
	at org.apache.aurora.common.args.ArgScanner.parse(ArgScanner.java:212) ~[commons-0.12.0-SNAPSHOT.jar:na]
	at org.apache.aurora.common.args.ArgScanner.parse(ArgScanner.java:190) ~[commons-0.12.0-SNAPSHOT.jar:na]
	at org.apache.aurora.common.args.ArgScanner.parse(ArgScanner.java:167) ~[commons-0.12.0-SNAPSHOT.jar:na]
	at org.apache.aurora.scheduler.app.SchedulerMain.applyStaticArgumentValues(SchedulerMain.java:230)
[aurora-0.12.0-SNAPSHOT.jar:na]
	at org.apache.aurora.scheduler.app.SchedulerMain.main(SchedulerMain.java:203) [aurora-0.12.0-SNAPSHOT.jar:na]
```


Thanks,

John Sirois


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message