aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zameer Manji" <zma...@apache.org>
Subject Re: Review Request 42328: Add metric for counting uncaught exceptions in async executor.
Date Fri, 15 Jan 2016 18:27:14 GMT


> On Jan. 15, 2016, 9:42 a.m., Maxim Khutornenko wrote:
> > NEWS, line 26
> > <https://reviews.apache.org/r/42328/diff/2/?file=1197752#file1197752line26>
> >
> >     It this really news-worthy? I'd expect it to be a low noise feature related
summary. IMO, adding a stat does not clear that bar.

Noted, I'll remove it from NEWS.


- Zameer


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42328/#review114724
-----------------------------------------------------------


On Jan. 14, 2016, 3:58 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42328/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2016, 3:58 p.m.)
> 
> 
> Review request for Aurora, John Sirois and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1582
>     https://issues.apache.org/jira/browse/AURORA-1582
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add metric "async_executor_uncaught_exceptions" for tracking uncaught exceptions in async
executor.
> 
> 
> Diffs
> -----
> 
>   NEWS 809077fe6f689e726204519f93fdabb89a4bb5e5 
>   src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java 5facc048bc21adb124cb761647553afa9f8ab724

> 
> Diff: https://reviews.apache.org/r/42328/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message