aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Amol Deshmukh" <adeshm...@twitter.com>
Subject Re: Review Request 42046: Allow for plugging in cli-configurable filters that are invoked post shiro filters.
Date Tue, 12 Jan 2016 01:15:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42046/
-----------------------------------------------------------

(Updated Jan. 12, 2016, 1:15 a.m.)


Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Bill Farner.


Changes
-------

- Refactored previous change to allow specifying the shiro post filter as a constructor arg
for tests.
- Updated existing tests with assertions for the new shiro post filter behavior.


Bugs: AURORA-1576
    https://issues.apache.org/jira/browse/AURORA-1576


Repository: aurora


Description
-------

Allow for plugging in cli-configurable filters that are invoked post shiro filters.


Diffs (updated)
-----

  src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java 4b6a872737e5934394e9511af7b6bd96c6034e72

  src/test/java/org/apache/aurora/scheduler/http/AbstractJettyTest.java 19c8a1fe06a333324022da11f74d7c96b2942587

  src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java ac92117e14c105bec74e49d8e80eb56008237abf


Diff: https://reviews.apache.org/r/42046/diff/


Testing
-------

Unit tests:
```
$ ./gradlew clean test
...
BUILD SUCCESSFUL

Total time: 3 mins 24.616 secs
```

End to end tests:
```
$ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
...

*** OK (All tests passed) ***

aurora-scheduler-kerberos stop/waiting
aurora-scheduler start/running, process 15362
+ RETCODE=0
+ restore_netrc
+ mv /home/vagrant/.netrc.bak /home/vagrant/.netrc
+ true
Connection to 127.0.0.1 closed.

```


Thanks,

Amol Deshmukh


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message