aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 42145: Use tags instead of branches for release candidates.
Date Mon, 11 Jan 2016 15:26:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42145/#review113764
-----------------------------------------------------------



build-support/release/release-candidate (line 29)
<https://reviews.apache.org/r/42145/#comment174569>

    I renamed this variable as i found it confusing to have `rc_tag_version` and `current_version_tag`
variables.



build-support/release/release-candidate 
<https://reviews.apache.org/r/42145/#comment174571>

    Looking through the commands, i didn't find that the use of `$base_dir` was necessary.
 I think the resulting code is simpler without it.


- Bill Farner


On Jan. 11, 2016, 7:22 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42145/
> -----------------------------------------------------------
> 
> (Updated Jan. 11, 2016, 7:22 a.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Follow-up from https://reviews.apache.org/r/42117 for release candidate script
> 
> 
> Diffs
> -----
> 
>   build-support/release/release-candidate 114bb6d284647ad9745679fa3d13684ffd45ac31 
> 
> Diff: https://reviews.apache.org/r/42145/diff/
> 
> 
> Testing
> -------
> 
> Ran `./build-support/release/release-candidate` in non-publish mode, verified files and
e-mail boilerplate generated.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message