aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 42046: Allow for plugging in cli-configurable filters that are invoked post shiro filters.
Date Sun, 10 Jan 2016 05:21:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42046/#review113638
-----------------------------------------------------------


-1, please add test coverage to mitigate likelihood of breaking this change.

- Bill Farner


On Jan. 8, 2016, 4:55 p.m., Amol Deshmukh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42046/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2016, 4:55 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Bill Farner.
> 
> 
> Bugs: AURORA-1576
>     https://issues.apache.org/jira/browse/AURORA-1576
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Allow for plugging in cli-configurable filters that are invoked post shiro filters.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java
4b6a872737e5934394e9511af7b6bd96c6034e72 
> 
> Diff: https://reviews.apache.org/r/42046/diff/
> 
> 
> Testing
> -------
> 
> Unit tests:
> ```
> $ ./gradlew clean test
> ...
> BUILD SUCCESSFUL
> 
> Total time: 3 mins 24.616 secs
> ```
> 
> End to end tests:
> ```
> $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ...
> 
> *** OK (All tests passed) ***
> 
> aurora-scheduler-kerberos stop/waiting
> aurora-scheduler start/running, process 15362
> + RETCODE=0
> + restore_netrc
> + mv /home/vagrant/.netrc.bak /home/vagrant/.netrc
> + true
> Connection to 127.0.0.1 closed.
> 
> ```
> 
> 
> Thanks,
> 
> Amol Deshmukh
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message