aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Martin Hrabovcin" <>
Subject Re: Review Request 40922: Thermos: Add ability to specify process outputs destination
Date Fri, 08 Jan 2016 10:54:28 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Jan. 8, 2016, 10:54 a.m.)

Review request for Aurora and John Sirois.


Bumping wait value back to 1 second. @ReviewBot retry

Bugs: AURORA-1548

Repository: aurora


This patch will provide way to **optionally** specify running process outputs destination.
Implementation was built on top of

**What was changed:**

New `destination` parameter is available on global cluster level and also on each `Process`
level. Possible options are `file` (default), `stream` to parent process stdout/stderr, `mixed`
will split output to files and stream and finally `none` to discard any logs produced by running

Diffs (updated)

  NEWS e2b26d9 
  docs/ bea99a7 
  docs/ c0988e8 
  src/main/python/apache/aurora/executor/bin/ cfade22 
  src/main/python/apache/aurora/executor/ c019fc9 
  src/main/python/apache/thermos/config/ 5552108 
  src/main/python/apache/thermos/core/ 8a181b0 
  src/main/python/apache/thermos/core/ 5623dce 
  src/main/python/apache/thermos/runner/ 3dacd45 
  src/test/python/apache/thermos/core/ da4c494 



Unit test coverage is provided for new functionality.

I did also manual testing with mesos/docker and I made sure that logs are being written to
expected files and also same output gets to docker daemon.


Martin Hrabovcin

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message