aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Sirois" <john.sir...@gmail.com>
Subject Re: Review Request 41915: Kill flaky TaskObserverTest.
Date Tue, 05 Jan 2016 05:15:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41915/
-----------------------------------------------------------

(Updated Jan. 4, 2016, 10:15 p.m.)


Review request for Aurora, Maxim Khutornenko and Bill Farner.


Changes
-------

Kill test_task_observer.py.

Fixup the associated BUILD as well.

 src/main/python/apache/thermos/observer/task_observer.py      |  5 ++---
 src/test/python/apache/thermos/observer/BUILD                 |  1 +
 src/test/python/apache/thermos/observer/test_task_observer.py | 57 --------------------------------------------------
 3 files changed, 3 insertions(+), 60 deletions(-)


Summary (updated)
-----------------

Kill flaky TaskObserverTest.


Bugs: AURORA-1570
    https://issues.apache.org/jira/browse/AURORA-1570


Repository: aurora


Description (updated)
-------

Previously, a mock threading.Event was waited on in one thread
and the count of waits was read in another thread.  Most thread
memory models do not guaranty reads are fresh in this scenario
unless there is a memory barrier of some sort forcing per-cpu
caches to be flushed.

Since the test really only verified correct conversion of a poll
interval to fractional seconds - kill the test as not pulling its
weight.

 src/test/python/apache/thermos/observer/BUILD                 |  1 +
 src/test/python/apache/thermos/observer/test_task_observer.py | 45 ---------------------------------------------
 2 files changed, 1 insertion(+), 45 deletions(-)


Diffs (updated)
-----

  src/test/python/apache/thermos/observer/BUILD f3f697c35ee5473072171926923459a4dde15545 
  src/test/python/apache/thermos/observer/test_task_observer.py ace15c5305e75fac3a82971f4d71b92bcb37bafc


Diff: https://reviews.apache.org/r/41915/diff/


Testing
-------

Before this change I got a failure between 1/5 and 1/10th of the
time via:
```
while true
do
  ./pants test src/test/python/apache/thermos/observer/ -- -kTaskObserverTest
done
```

After the change I cannot trigger the failure.


Thanks,

John Sirois


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message