aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Sirois" <john.sir...@gmail.com>
Subject Re: Review Request 41897: Upgrade to the latest zk point release.
Date Mon, 04 Jan 2016 23:57:01 GMT


> On Jan. 4, 2016, 4:20 p.m., Aurora ReviewBot wrote:
> > Master (8706a78) is red with this patch.
> >   ./build-support/jenkins/build.sh
> > 
> >                      src/test/python/apache/thermos/observer/test_detector.py::test_observer_task_detector_standard_transitions
PASSED
> >                      src/test/python/apache/thermos/observer/test_detector.py::test_observer_task_detector_nonstandard_transitions
PASSED
> >                      src/test/python/apache/thermos/observer/test_task_observer.py::TaskObserverTest::test_run_loop
FAILED
> >                      
> >                      ==================== FAILURES ====================
> >                      _________ TaskObserverTest.test_run_loop _________
> >                      
> >                      self = <test_task_observer.TaskObserverTest testMethod=test_run_loop>
> >                      
> >                          def test_run_loop(self):
> >                            """Test observer run loop."""
> >                            mock_task_detector = create_autospec(spec=ObserverTaskDetector)
> >                            with patch(
> >                                "apache.thermos.observer.task_observer.ObserverTaskDetector",
> >                                return_value=mock_task_detector) as mock_detector:
> >                              with patch('threading._Event.wait') as mock_wait:
> >                          
> >                                run_count = 3
> >                                interval = 15
> >                                observer = TaskObserver(mock_detector, interval=Amount(interval,
Time.SECONDS))
> >                                observer.start()
> >                                while len(mock_wait.mock_calls) < run_count:
> >                                  pass
> >                          
> >                                observer.stop()
> >                          
> >                      >         assert len(mock_task_detector.mock_calls)
>= run_count
> >                      E         AssertionError: assert 1 >= 3
> >                      E          +  where 1 = len([call.refresh()])
> >                      E          +    where [call.refresh()] = <MagicMock
spec='ObserverTaskDetector' id='140389955602192'>.mock_calls
> >                      
> >                      src/test/python/apache/thermos/observer/test_task_observer.py:42:
AssertionError
> >                       generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/src.test.python.apache.thermos.observer.observer.xml

> >                      ======= 1 failed, 3 passed in 0.25 seconds =======
> >                      
> > FAILURE
> > 
> > 
> > 23:20:37 04:05   [complete]
> >                FAILURE
> > 
> > 
> > I will refresh this build result if you post a review containing "@ReviewBot retry"
> 
> John Sirois wrote:
>     I found no jira issue but will file shortly: Anyone recall if this is known flaky?

Filed https://issues.apache.org/jira/browse/AURORA-1570


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41897/#review112683
-----------------------------------------------------------


On Jan. 4, 2016, 4:44 p.m., John Sirois wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41897/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2016, 4:44 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko, Stephan Erb, and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This is enabled by https://reviews.apache.org/r/41895/ which
> isolated the kerberos configuration.
> 
>  build.gradle | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> 
> Diffs
> -----
> 
>   NEWS c0c454d080023a2e2796022f957a4d47bdb87b41 
>   build.gradle c1bbb08305b446c2d8aec8d1bf8c6f2299a9db75 
> 
> Diff: https://reviews.apache.org/r/41897/diff/
> 
> 
> Testing
> -------
> 
> Both `./build-support/jenkins/build.sh` and
> `./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh` ran
> green locally.
> 
> 
> Thanks,
> 
> John Sirois
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message