aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tony Dong" <tonydon...@gmail.com>
Subject Re: Review Request 41717: Very Very WIP: Add jittering as an option to BackoffStrategy.
Date Sun, 03 Jan 2016 15:23:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41717/
-----------------------------------------------------------

(Updated Jan. 3, 2016, 3:23 p.m.)


Review request for Aurora, Stephan Erb and Bill Farner.


Repository: aurora


Description
-------

The general idea is that we should be able to specify different
types of BackoffStrategies, with varying configurations and all
the legwork will be handled via injection. This change not only
introduces different BackoffStrategies which can be selected via
command line arguments, but also introduces a BackoffOptions
class which makes configuring these different strategies more
standardized.

- TODO: Update everywhere that uses BackoffStrategy to use Injection.
- TODO: Add tests for all the different backoff strategies.
- TODO: Add tests for nextLong().
- TODO: Make BackoffHelper injectable and configurable with the BackoffStrategy Types.
- TODO: Update Docs everywhere.


Diffs (updated)
-----

  commons/src/main/java/org/apache/aurora/common/args/parsers/EnumParser.java 9f6a3ff977ef6a0e2d472a8e2cf90e7f9a63a985

  commons/src/main/java/org/apache/aurora/common/util/TruncatedBinaryBackoff.java fd74b9f37c6cc24c7ea1cb239ba6354661d931e2

  commons/src/test/java/org/apache/aurora/common/util/TruncatedBinaryBackoffTest.java 127a60331f8560d98733bd16654087f840abef72

  src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java fbc589e9a7592cce6d92c4e987cde2e056406c3a

  src/main/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculator.java 291bf5f0baefef6dd10d19ec89e173ce495e6380


Diff: https://reviews.apache.org/r/41717/diff/


Testing
-------


Thanks,

Tony Dong


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message