Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@aurora.apache.org
Content-Type: multipart/alternative;
 boundary="===============1675349620319743364=="
MIME-Version: 1.0
Subject: Re: Review Request 41565: Improve review_feedback.py testability.
From: "Bill Farner" <wfarner@apache.org>
To: "Bill Farner" <wfarner@apache.org>
Cc: "Aurora ReviewBot" <wfarner@apache.org>,
 "John Sirois" <john.sirois@gmail.com>, "Aurora" <reviews@aurora.apache.org>
Date: Fri, 18 Dec 2015 20:40:37 -0000
Message-ID: <20151218204037.1672.61361@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Bill Farner" <noreply@reviews.apache.org>
References: <20151218201347.1673.97695@reviews.apache.org>
In-Reply-To: <20151218201347.1673.97695@reviews.apache.org>
Reply-To: "Bill Farner" <wfarner@apache.org>

--===============1675349620319743364==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On Dec. 18, 2015, 12:13 p.m., Aurora ReviewBot wrote:
> > Master (1c73438) is green with this patch.
> >   ./build-support/jenkins/build.sh
> > 
> > I will refresh this build result if you post a review containing "@ReviewBot retry"
> 
> John Sirois wrote:
>     Bill - I'm ignorant of the Jenkins setup - is this using my changes live or is a special deploy step needed to use `review_feedback.py` edits?

It was not used in this review run, but will be used from master in subsequent runs.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41565/#review111257
-----------------------------------------------------------


On Dec. 18, 2015, noon, John Sirois wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41565/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2015, noon)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Support host-or-base-url for easier local non-https testing.
> Don't require a defaulted arg and don't require --git-clean-excludes.
> 
>  build-support/jenkins/review_feedback.py | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> 
> Diffs
> -----
> 
>   build-support/jenkins/review_feedback.py fcf574ab508e87992440b873e80744040658181e 
> 
> Diff: https://reviews.apache.org/r/41565/diff/
> 
> 
> Testing
> -------
> 
> Locally against a local RB install:
> ```
> $ ./build-support/jenkins/review_feedback.py --server http://localhost:8888 --repository aurora --reviewboard-credentials-file ~/.aurorabot.creds --command true
> Request: http://localhost:8888/api/repositories/?name=aurora
> Request: http://localhost:8888/api/review-requests/?status=pending&repository=1
> Found 1 review requests to inspect
> Inspecting review 2: Support host-or-base-url for easier local non-https testing.
> Request: http://localhost:8888/api/review-requests/2/reviews/
> Request: http://localhost:8888/api/review-requests/2/diffs/
> Latest feedback was given at        2015-12-16T18:50:13Z
> Latest build request from a user at 2015-12-16T18:50:13Z
> Latest diff was posted at           2015-12-16T18:49:55Z
> ```
> 
> 
> Thanks,
> 
> John Sirois
> 
>


--===============1675349620319743364==--