Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3C34E181DD for ; Wed, 16 Dec 2015 22:43:11 +0000 (UTC) Received: (qmail 66700 invoked by uid 500); 16 Dec 2015 22:43:11 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 66648 invoked by uid 500); 16 Dec 2015 22:43:11 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 66617 invoked by uid 99); 16 Dec 2015 22:43:10 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 Dec 2015 22:43:10 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 3194B2AEB55; Wed, 16 Dec 2015 22:43:10 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1789277414618359087==" MIME-Version: 1.0 Subject: Re: Review Request 41428: Refactoring HealthCheckConfig into separate structs From: "Dmitriy Shirchenko" To: "Joshua Cohen" , "Bill Farner" , "Maxim Khutornenko" Cc: "John Sirois" , "Zameer Manji" , "Aurora" , "Dmitriy Shirchenko" , "Aurora ReviewBot" Date: Wed, 16 Dec 2015 22:43:10 -0000 Message-ID: <20151216224310.31807.57484@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Dmitriy Shirchenko" X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/41428/ X-Sender: "Dmitriy Shirchenko" References: <20151216190859.31807.50197@reviews.apache.org> In-Reply-To: <20151216190859.31807.50197@reviews.apache.org> Reply-To: "Dmitriy Shirchenko" X-ReviewRequest-Repository: aurora --===============1789277414618359087== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41428/ ----------------------------------------------------------- (Updated Dec. 16, 2015, 10:43 p.m.) Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Bill Farner. Bugs: AURORA-1562 https://issues.apache.org/jira/browse/AURORA-1562 Repository: aurora Description ------- Refactoring HealthCheckConfig into separate structs Diffs (updated) ----- docs/configuration-reference.md 07149c7f49371e39b70e8744d60affeffd73c77f src/main/python/apache/aurora/client/config.py 161c3627db0afa8fdd8afff5abf6a94556f53180 src/main/python/apache/aurora/config/schema/base.py e752482b95ae6377d0cf12cf0ecf0fa60e2a5d46 src/main/python/apache/aurora/executor/common/health_checker.py cba4e8c879fae2b9f56a36bf8fa4b702163667d1 src/test/python/apache/aurora/client/test_config.py 8fd112fd8a10120f57324d8efec22a009b93404b src/test/python/apache/aurora/executor/common/test_health_checker.py 8561abc3e7df8803785b70064bb76553d3210399 src/test/sh/org/apache/aurora/e2e/http/http_example_bad_healthcheck.aurora 37f2e9c6ebc4a4bbd6089e821420e5a02179c6b9 Diff: https://reviews.apache.org/r/41428/diff/ Testing ------- Added unit tests. Changed end to end test. Thanks, Dmitriy Shirchenko --===============1789277414618359087==--