Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@aurora.apache.org
Content-Type: multipart/alternative;
 boundary="===============3352046304008554330=="
MIME-Version: 1.0
Subject: Re: Review Request 41201: Preserve env variables for tasks in docker
From: "Aurora ReviewBot" <wfarner@apache.org>
To: "Aurora ReviewBot" <wfarner@apache.org>,
 "Aurora" <reviews@aurora.apache.org>, "Kasisnu Singh" <kasisnu@gmail.com>
Date: Wed, 16 Dec 2015 18:52:35 -0000
Message-ID: <20151216185235.19750.91494@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Aurora ReviewBot" <noreply@reviews.apache.org>
References: <20151216164146.19750.77738@reviews.apache.org>
In-Reply-To: <20151216164146.19750.77738@reviews.apache.org>
Reply-To: "Aurora ReviewBot" <wfarner@apache.org>

--===============3352046304008554330==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41201/#review110718
-----------------------------------------------------------


Master (fb8155d) is red with this patch.
  ./build-support/jenkins/build.sh

virtualenv-12.1.1/virtualenv_embedded/activate.sh
virtualenv-12.1.1/virtualenv_embedded/activate_this.py
virtualenv-12.1.1/virtualenv_embedded/deactivate.bat
virtualenv-12.1.1/virtualenv_embedded/distutils-init.py
virtualenv-12.1.1/virtualenv_embedded/distutils.cfg
virtualenv-12.1.1/virtualenv_embedded/site.py
virtualenv-12.1.1/virtualenv_support/
virtualenv-12.1.1/virtualenv_support/__init__.py
virtualenv-12.1.1/virtualenv_support/pip-6.1.1-py2.py3-none-any.whl
virtualenv-12.1.1/virtualenv_support/setuptools-15.0-py2.py3-none-any.whl
+ touch virtualenv-12.1.1/BOOTSTRAPPED
+ popd
~/jenkins-slave/workspace/AuroraBot
+ exec /usr/bin/python2.7 /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/virtualenv-12.1.1/virtualenv.py /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv
New python executable in /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/bin/python2.7
Also creating executable in /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/bin/python
Installing setuptools, pip...done.
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/local/lib/python2.7/site-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:79: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. For more information, see https://urllib3.readthedocs.org/en/latest/security.html#insecureplatformwarning.
  InsecurePlatformWarning
You are using pip version 6.1.1, however version 7.1.2 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
Collecting isort==4.0.0
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/local/lib/python2.7/site-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:79: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. For more information, see https://urllib3.readthedocs.org/en/latest/security.html#insecureplatformwarning.
  InsecurePlatformWarning
  Using cached isort-4.0.0-py2.py3-none-any.whl
Installing collected packages: isort
Successfully installed isort-4.0.0
ERROR: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/core/process.py Imports are incorrectly sorted.
--- /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/core/process.py:before	2015-12-16 18:46:29.567038
+++ /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/core/process.py:after	2015-12-16 18:52:33.563286
@@ -27,8 +27,8 @@
 import subprocess
 import sys
 import time
+from abc import abstractmethod
 from copy import deepcopy
-from abc import abstractmethod
 
 from twitter.common import log
 from twitter.common.dirutil import lock_file, safe_mkdir, safe_open


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Dec. 16, 2015, 4:41 p.m., Kasisnu Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41201/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2015, 4:41 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Preserve env variables for tasks in docker
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 0d02dc17da4d496560ea572659e281c736170da2 
>   src/main/python/apache/aurora/executor/thermos_task_runner.py 14e8b4bd539d2c295582d93fa01b5613345c1758 
>   src/main/python/apache/thermos/core/process.py f214bccbd6f3be795e0fa9a259d27b01b81ab655 
>   src/main/python/apache/thermos/core/runner.py f949f279a071c6464b026749f51afc776102f2aa 
>   src/main/python/apache/thermos/runner/thermos_runner.py bd8cf7f4cda54b6be72dad64f9446eedeb132211 
> 
> Diff: https://reviews.apache.org/r/41201/diff/
> 
> 
> Testing
> -------
> 
> Ran ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh with no failures and did manual testing for env variables in containers.
> 
> 
> Thanks,
> 
> Kasisnu Singh
> 
>


--===============3352046304008554330==--