Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6418D18DE5 for ; Fri, 11 Dec 2015 04:30:22 +0000 (UTC) Received: (qmail 85033 invoked by uid 500); 11 Dec 2015 04:30:22 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 84977 invoked by uid 500); 11 Dec 2015 04:30:22 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 84936 invoked by uid 99); 11 Dec 2015 04:30:21 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 11 Dec 2015 04:30:21 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 6E1482932B3; Fri, 11 Dec 2015 04:30:21 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4530841784248755737==" MIME-Version: 1.0 Subject: Re: Review Request 41154: Add support for performing health checks with a shell command. From: "Joshua Cohen" To: "Bill Farner" , "Maxim Khutornenko" , "Zameer Manji" Cc: "Joshua Cohen" , "Dmitriy Shirchenko" , "Aurora" Date: Fri, 11 Dec 2015 04:30:21 -0000 Message-ID: <20151211043021.1618.30140@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Joshua Cohen" X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/41154/ X-Sender: "Joshua Cohen" References: <20151211023651.1618.95662@reviews.apache.org> In-Reply-To: <20151211023651.1618.95662@reviews.apache.org> Reply-To: "Joshua Cohen" X-ReviewRequest-Repository: aurora --===============4530841784248755737== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41154/#review109914 ----------------------------------------------------------- src/main/python/apache/aurora/common/health_check/shell.py (line 47) Should we use `shlex.split` here instead? - Joshua Cohen On Dec. 11, 2015, 2:36 a.m., Dmitriy Shirchenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41154/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2015, 2:36 a.m.) > > > Review request for Aurora, Maxim Khutornenko, Bill Farner, and Zameer Manji. > > > Bugs: AURORA-1551 > https://issues.apache.org/jira/browse/AURORA-1551 > > > Repository: aurora > > > Description > ------- > > Adding support for non-HTTP health checks. > > > Diffs > ----- > > 3rdparty/python/requirements.txt cfef18ee66b0f92d83c53dacb6d9376fc2e50445 > docs/configuration-reference.md 364292998bebb233d300fe59c9ea42b216deee81 > src/main/python/apache/aurora/client/config.py 2fc12559016d406c347adb416a5166cca31c961e > src/main/python/apache/aurora/common/BUILD 5fce3d0d29d2a38c6563b4d9be963532e595ee19 > src/main/python/apache/aurora/common/health_check/__init__.py PRE-CREATION > src/main/python/apache/aurora/common/health_check/shell.py PRE-CREATION > src/main/python/apache/aurora/common/http_signaler.py a3193f3259276ec23d37f45839afe3c387cff6b1 > src/main/python/apache/aurora/config/schema/base.py 398f737bed9ef02ce4a5636896d6587bce26501e > src/main/python/apache/aurora/executor/common/health_checker.py 03fdf0afef120c365c6ffad09e152780eed7e351 > src/main/python/apache/aurora/executor/http_lifecycle.py 6d578cceb56375425ccac1cbfbbcd0add60f20e9 > src/test/python/apache/aurora/client/BUILD 84c5c845d9b1c8078ae8b47242d0f2ffc00ef6dc > src/test/python/apache/aurora/client/test_config.py b1a3c1865819899ef19173be0f861783a2631d0a > src/test/python/apache/aurora/common/BUILD 2556c32842b3cf7040cb3c41172a0d9c365cb649 > src/test/python/apache/aurora/common/health_check/BUILD PRE-CREATION > src/test/python/apache/aurora/common/health_check/__init__.py PRE-CREATION > src/test/python/apache/aurora/common/health_check/test_shell.py PRE-CREATION > src/test/python/apache/aurora/common/test_http_signaler.py f68c71a6765f7f0b93c8c50662515b5742344f35 > src/test/python/apache/aurora/executor/common/test_health_checker.py 27c71711d52f757ed1552db4accda671a6bdafdd > > Diff: https://reviews.apache.org/r/41154/diff/ > > > Testing > ------- > > Added unit tests. > Ran e2e test. > Tested expected behavior on virtual Mesos cluster. > > > Thanks, > > Dmitriy Shirchenko > > --===============4530841784248755737==--