Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B60BA18286 for ; Thu, 10 Dec 2015 22:33:41 +0000 (UTC) Received: (qmail 81125 invoked by uid 500); 10 Dec 2015 22:33:41 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 81074 invoked by uid 500); 10 Dec 2015 22:33:41 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 81052 invoked by uid 99); 10 Dec 2015 22:33:41 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 10 Dec 2015 22:33:41 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id DD5652930B3; Thu, 10 Dec 2015 22:33:40 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6720300637037629525==" MIME-Version: 1.0 Subject: Re: Review Request 41226: Handling DELETED task race in updater KillTask. From: "Aurora ReviewBot" To: "Bill Farner" Cc: "Aurora ReviewBot" , "Maxim Khutornenko" , "Aurora" Date: Thu, 10 Dec 2015 22:33:40 -0000 Message-ID: <20151210223340.1618.10329@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Aurora ReviewBot" X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/41226/ X-Sender: "Aurora ReviewBot" References: <20151210221611.1618.57458@reviews.apache.org> In-Reply-To: <20151210221611.1618.57458@reviews.apache.org> Reply-To: "Aurora ReviewBot" X-ReviewRequest-Repository: aurora --===============6720300637037629525== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41226/#review109879 ----------------------------------------------------------- Ship it! Master (6933a71) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Dec. 10, 2015, 10:16 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41226/ > ----------------------------------------------------------- > > (Updated Dec. 10, 2015, 10:16 p.m.) > > > Review request for Aurora and Bill Farner. > > > Bugs: AURORA-1506 > https://issues.apache.org/jira/browse/AURORA-1506 > > > Repository: aurora > > > Description > ------- > > The KillTask should not throw when attempting to fetch a task to kill. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/updater/InstanceActionHandler.java d8686f1f1b53e5ff2791663489e24c342503831e > src/test/java/org/apache/aurora/scheduler/updater/KillTaskTest.java PRE-CREATION > > Diff: https://reviews.apache.org/r/41226/diff/ > > > Testing > ------- > > ./gradlew -Pq build > > > Thanks, > > Maxim Khutornenko > > --===============6720300637037629525==--