aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Sirois" <john.sir...@gmail.com>
Subject Review Request 41834: Simplify thrift service metadata.
Date Thu, 31 Dec 2015 20:38:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41834/
-----------------------------------------------------------

Review request for Aurora and Bill Farner.


Repository: aurora


Description
-------

This leverages java.lang.reflect.Parameter.getName as enabled by turning
on emission of parameter names in the debug info for aurora classfiles.

The IDEA project config is also fixed up to do the same.

 build.gradle                                                         |  9 +++++++++
 buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy |  2 ++
 src/main/java/org/apache/aurora/scheduler/http/api/ApiBeta.java      | 26 ++++++++++++--------------
 src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py   | 40 ++++++++++------------------------------
 4 files changed, 33 insertions(+), 44 deletions(-)


Diffs
-----

  build.gradle 5ff10d90fa8f748b066faf1c4ec385b22dd883b4 
  buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy 44cb723728fd4ca54961856202e15ae093fa1ca4

  src/main/java/org/apache/aurora/scheduler/http/api/ApiBeta.java b889f9354228833ffd486c951957161d5da737c2

  src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py 49cfa9fbaa5a8aeba973df142d8f29f6e37564b6


Diff: https://reviews.apache.org/r/41834/diff/


Testing
-------

Locally green `./build-support/jenkins/build.sh` as well as a green run
of `ApiBetaTest` from within IDEA using `./gradlew idea` to gen a new
project.


Thanks,

John Sirois


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message