aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Sirois" <john.sir...@gmail.com>
Subject Review Request 41812: Fixup multi-parent error message.
Date Wed, 30 Dec 2015 23:33:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41812/
-----------------------------------------------------------

Review request for Aurora and Bill Farner.


Repository: aurora


Description
-------

The error message generation was itself failing.  The depends_on field
looks like so:
```
"depends_on": [
 {
   "href": "https://reviews.apache.org/api/review-requests/41762/",
   "method": "GET",
   "title": "Upgrade ZooKeeper dep to 3.4.2"
 },
 {
   "href": "https://reviews.apache.org/api/review-requests/41777/",
   "method": "GET",
   "title": "Use slf4j throughout the scheduler."
 }
],
```

This change just uses href since thats more directly useful to the reader
than the RB id number.

 build-support/jenkins/review_feedback.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


Diffs
-----

  build-support/jenkins/review_feedback.py aa2c836ad453a52bac29020a3be2c4f614b0ee8a 

Diff: https://reviews.apache.org/r/41812/diff/


Testing
-------

Manual curling of the api to check the schema for this correction.


Thanks,

John Sirois


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message