aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 41809: Allow custom announce path
Date Wed, 30 Dec 2015 23:32:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41809/#review112352
-----------------------------------------------------------


Pausing review here - in-flight discussion on the linked ticket.

- Bill Farner


On Dec. 30, 2015, 2:51 p.m., Kunal Thakar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41809/
> -----------------------------------------------------------
> 
> (Updated Dec. 30, 2015, 2:51 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Allow custom announce path
> 
> Related ticket: https://issues.apache.org/jira/browse/AURORA-1569
> 
> 
> Diffs
> -----
> 
>   docs/configuration-reference.md cf63cfa487c531b56f5238a4768e1e9e9ac1c30b 
>   src/main/python/apache/aurora/config/schema/base.py 69182c320579bf5100e5646904c8ce1336afdebb

>   src/main/python/apache/aurora/executor/common/announcer.py dda76f018f472d7d8228459eb89f4c5daf9df26d

>   src/test/python/apache/aurora/executor/common/test_announcer.py 46ad784987b626e10e235831707540b807158955

> 
> Diff: https://reviews.apache.org/r/41809/diff/
> 
> 
> Testing
> -------
> 
> Ran unit tests ./pants test src/test/python/apache/aurora:all
> Manually tested the changes in vagrant.
> 
> 
> Thanks,
> 
> Kunal Thakar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message