aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aurora ReviewBot" <wfar...@apache.org>
Subject Re: Review Request 41785: Remove scheduler log scaffolding, advise configuration of java.util.logging for now.
Date Wed, 30 Dec 2015 00:55:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41785/#review112273
-----------------------------------------------------------


Master (80ae5e8) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Dec. 30, 2015, 12:49 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41785/
> -----------------------------------------------------------
> 
> (Updated Dec. 30, 2015, 12:49 a.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Remove scheduler log scaffolding, advise configuration of java.util.logging for now.
> 
> Note: the use of java.util.logging may be short-lived.  I'd like to settle on our logging
backend before releasing 0.12.0.  I have another review in flight that will put us in a better
position to make that call soon: https://reviews.apache.org/r/41777/
> 
> 
> Diffs
> -----
> 
>   NEWS 394b31cf1c863c54b89e7f27ab3694bdd51b2eeb 
>   build.gradle 5ff10d90fa8f748b066faf1c4ec385b22dd883b4 
>   commons/src/main/java/org/apache/aurora/common/logging/LogFormatter.java 0cb621da2b2f286d9eda9eb18ecac087208d7b6b

>   commons/src/main/java/org/apache/aurora/common/logging/RootLogConfig.java 26dd0aa5682faf31ba4cc086d32bf61557ef1fde

>   commons/src/main/java/org/apache/aurora/common/logging/log4j/GlogLayout.java 1a90ded72c81a7e3fdc9dab515a2622c55563e6a

>   commons/src/test/java/org/apache/aurora/common/logging/RootLogConfigTest.java 9d55a1aaf555d6e25ad97622612fad61271d0e25

>   examples/vagrant/logging.properties PRE-CREATION 
>   examples/vagrant/upstart/aurora-scheduler-kerberos.conf 4f43892723db4744db205ea7dd107e9e9ce9d5db

>   examples/vagrant/upstart/aurora-scheduler.conf 4033184451f36cb5f0233ea96e3dceaae6741275

>   src/main/java/org/apache/aurora/scheduler/app/Log4jConfigurator.java 28aad86b27b09c8b72c7a92cf5568d5493b4ff47

>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 3822d6e734e232bbb194e749f0cfa1f8fc4ebcf9

> 
> Diff: https://reviews.apache.org/r/41785/diff/
> 
> 
> Testing
> -------
> 
> end-to-end tests are green
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message