aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Sirois" <john.sir...@gmail.com>
Subject Re: Review Request 41778: Proposal: simplify test BUILD files to one target per directory.
Date Tue, 29 Dec 2015 22:00:03 GMT


> On Dec. 29, 2015, 2:54 p.m., Joshua Cohen wrote:
> > I'm generally ok with this this. The main benefit of smaller target groups is faster
test runs, but tbh, I've probably spent more time looking up which smaller target has the
tests I want to run than I've saved ;).

And - fwiw, the test discovery is pretty fast such that `./pants test :: -- -ktest_module_name`
is good enough for a medium sized python project like this since chroots are now cached.
... except for aurora's current need to --no-fast (sealed in in pants.ini), so this is really
`./pants test.pytest --fast :: -- -ktest_non_hooked_api` and there are more oddities - dup
module names + pytest ... but - FWIW.


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41778/#review112223
-----------------------------------------------------------


On Dec. 29, 2015, 2:39 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41778/
> -----------------------------------------------------------
> 
> (Updated Dec. 29, 2015, 2:39 p.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> I'm using this file as a proposed convention for test targets in `BUILD` files.  In addition
to being less redundant, i find the resulting file much easier to understand.  In the past
when refactoring, i can find it nightmarish to go back and bring all the build targets back
into line (often repeating myself with imports changed in code).
> 
> If this proposal is accepted, i would like to further propose we collapse our `BUILD`
files into one target for all python tests.
> 
> Note that this patch is related to https://issues.apache.org/jira/browse/AURORA-959
> 
> 
> Diffs
> -----
> 
>   src/test/python/apache/aurora/client/api/BUILD 2a55cec51324c18debf10a1da93a74043f288a93

> 
> Diff: https://reviews.apache.org/r/41778/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message