aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 41762: Upgrade ZooKeeper dep to 3.4.2
Date Tue, 29 Dec 2015 17:01:02 GMT


> On Dec. 29, 2015, 8:43 a.m., John Sirois wrote:
> > commons/src/main/java/org/apache/aurora/common/zookeeper/testing/ZooKeeperTestServer.java,
line 83
> > <https://reviews.apache.org/r/41762/diff/1/?file=1177135#file1177135line83>
> >
> >     '..., max 60 conections is ...' would be an even more helpful comment

Done.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41762/#review112169
-----------------------------------------------------------


On Dec. 28, 2015, 7:07 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41762/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2015, 7:07 p.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Primary motivation here is to get past 3.4.0, which changed how logging works in ZK (primarily
via slf4j).  This will make it easier to have a cohesive logging story.
> 
> There was some fallout - I did not update to latest - 3.4.7.  I encountered issues with
a kerberos-related test (see comment in `build.gradle`) with >=3.4.3.  I spent a few minutes
looking for a solution, but decided to stop short so as to return to the work i was really
trying to tackle.
> 
> 
> Diffs
> -----
> 
>   build.gradle d32aea5e4c888cb215af7bedd5e9c1a8f41308c8 
>   commons/src/main/java/org/apache/aurora/common/zookeeper/testing/ZooKeeperTestServer.java
03d47c37f67dee64eca2107ab1510c7efcdd0931 
> 
> Diff: https://reviews.apache.org/r/41762/diff/
> 
> 
> Testing
> -------
> 
> end-to-end tests
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message