aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stephan Erb" <step...@dev.static-void.de>
Subject Re: Review Request 41725: Add component deployment diagram
Date Sun, 27 Dec 2015 20:52:38 GMT


> On Dec. 27, 2015, 9:32 p.m., Bill Farner wrote:
> > Thanks, this is a great addition!  Since i can't use `rbt` to apply this patch,
i'll pull it from your branch on github instead.  Can you squash that branch to a single commit?
 I'd like to just cherry-pick your commit to preserve authorship information.
> 
> John Sirois wrote:
>     FWIW, you can use this trick if there is no associated PR:
>     `curl -sSL https://github.com/apache/aurora/compare/master...StephanErb:fmc.patch
| git am -3`
> 
> John Sirois wrote:
>     ... and then `git rebase -i` to form the single commit.

Just in case, I've pushed a squashed commit to https://github.com/StephanErb/aurora/tree/fmc-squashed


- Stephan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41725/#review111932
-----------------------------------------------------------


On Dec. 26, 2015, 8:53 p.m., Stephan Erb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41725/
> -----------------------------------------------------------
> 
> (Updated Dec. 26, 2015, 8:53 p.m.)
> 
> 
> Review request for Aurora, Jay Buffington and Bill Farner.
> 
> 
> Bugs: AURORA-852
>     https://issues.apache.org/jira/browse/AURORA-852
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> FMC Blockdiagram (http://www.fmc-modeling.org/) of Aurora components, showing their communication
paths and deployment. 
> 
> Given that this manual is targeting beginners, the diagram sacrifices completeness in
order to stay simple.
> 
> 
> Diffs
> -----
> 
>   .gitattributes c41ea77f6e4f6b6a2e2d76f9bf96f1332dc7fe96 
>   docs/images/components.odg PRE-CREATION 
>   docs/images/components.png PRE-CREATION 
>   docs/installing.md 070bc82703b0823346286ef79838f08023facfd1 
> 
> Diff: https://reviews.apache.org/r/41725/diff/
> 
> 
> Testing
> -------
> 
> Rendered page is available at https://github.com/StephanErb/aurora/blob/fmc/docs/installing.md
> 
> 
> File Attachments
> ----------------
> 
> Components
>   https://reviews.apache.org/media/uploaded/files/2015/12/26/d1f51a1e-9125-40cf-a5a5-184c7aeacdcf__components.png
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message