aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aurora ReviewBot" <wfar...@apache.org>
Subject Re: Review Request 41711: Move all command line argument declarations to modules or SchedulerMain.
Date Thu, 24 Dec 2015 23:04:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41711/#review111883
-----------------------------------------------------------

Ship it!


Master (1ae77d5) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Dec. 24, 2015, 10:43 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41711/
> -----------------------------------------------------------
> 
> (Updated Dec. 24, 2015, 10:43 p.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This is a refactor to make all command line argument values injectable.  This is the
first of several steps that would prepare us for changing command line arg libraries, but
is also better practice for testability.
> 
> 
> Diffs
> -----
> 
>   commons/src/main/java/org/apache/aurora/common/logging/RootLogConfig.java 7f010fd7dbd491d8bc4c9664c1edf7fdd7661497

>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 967e10d2b6469ed985308594296f1b2f71f034f1

>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java e8bf6bc87cbab3f7496b4e3eadb21808ec0bf1b4

>   src/main/java/org/apache/aurora/scheduler/base/JobKeys.java 0ffec91ed29f17ca826cf54eff6075da8d371d50

>   src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 2cdb2f21202c09b6308e3cfa75d2255699b4c2e5

>   src/main/java/org/apache/aurora/scheduler/base/UserProvidedStrings.java PRE-CREATION

>   src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 3a2056a858eff5cc692b37c924dda48230caf006

>   src/main/java/org/apache/aurora/scheduler/configuration/SanitizedConfiguration.java
05981b9318a6c25703994436e8e91fdbf9522d77 
>   src/main/java/org/apache/aurora/scheduler/cron/SanitizedCronJob.java dd8c9cdaebc6bebe0e029b47ae3aa670d2af5cbb

>   src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java f355bc101252fb433c7437a791e6e92f94462fa6

>   src/main/java/org/apache/aurora/scheduler/cron/quartz/CronLifecycle.java 527197c3b7a37c1c87fbd4da5493d053fc9d48d7

>   src/main/java/org/apache/aurora/scheduler/storage/mem/InMemStoresModule.java f964853c168abbb2852c6ed0cc6293ec5ccab8b9

>   src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 01448ae1d2b1c2cddd1284d0cbc8aafa5fb6f397

>   src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 7235902b4728e055545dedcefeddd907648d5895

>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java fd5e2f25802697b7da0db472bc375a9e04f07ac3

>   src/main/java/org/apache/aurora/scheduler/thrift/Thresholds.java PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
c6a4ac58479402dd605c8db6de42065f376c7657 
>   src/test/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJobTest.java 5dd4aba92b2627b646087fce8118d5ebfeb75f49

>   src/test/java/org/apache/aurora/scheduler/cron/quartz/CronIT.java 17d12c3aa82c02991259424b1b109957e4350702

>   src/test/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImplTest.java 716e0a10ad99213bf496215fde5267f655304a22

>   src/test/java/org/apache/aurora/scheduler/cron/quartz/QuartzTestUtil.java 13cb73d0e314c043aed9ab2aacea1908c069a297

>   src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java 011b79aa02b0d00424a2d4b7ab1c22adaaff0360

>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
129851cb4a3d5e2bb82f2aba45aa8b1a7206c731 
>   src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 72b5c30e5e5ceb81eda090d5d2b8d5b213b04dc3

> 
> Diff: https://reviews.apache.org/r/41711/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message