aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Renan DelValle" <rdelv...@binghamton.edu>
Subject Re: Review Request 41473: Accept a command line argument for an executor configuration via json
Date Thu, 17 Dec 2015 21:10:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41473/
-----------------------------------------------------------

(Updated Dec. 17, 2015, 9:10 p.m.)


Review request for Aurora.


Changes
-------

Apologies, need to fix my other repo, this is from a clean one.


Repository: aurora


Description
-------

Patch to allow Aurora to accept an executor config via commandline which overrides the default
thermos one.


Diffs (updated)
-----

  src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java d04763418f55aa1e9f1b537987d21920c05fd950


Diff: https://reviews.apache.org/r/41473/diff/


Testing
-------

./build-support/jenkins/build.sh
bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh

Tested with the following config files:
CommandExec.json
```json
{
  "executor": {
    "name": "commandExec",
    "command": {
      "value": "echo 'Hello World from Aurora!'"
    },
    "resources": [
      {
        "name": "cpus",
        "type": "SCALAR",
        "scalar": {
          "value": 0.25
        }
      },
      {
        "name": "mem",
        "type": "SCALAR",
        "scalar": {
          "value": 128
        }
      }
    ]
  }
}
```
Thermos.json:
```json
{
  "executor": {
    "name": "thermos",
    "command": {
      "value": "./thermos_executor.pex",
      "arguments": [
        "--announcer-enable",
        "--announcer-ensemble",
        "localhost:2181"
      ],
      "uris": [
        {
          "value": "/home/vagrant/aurora/dist/thermos_executor.pex",
          "executable": true,
          "extract": false,
          "cache": false
        }
      ]
    },
    "resources": [
      {
        "name": "cpus",
        "type": "SCALAR",
        "scalar": {
          "value": 0.25
        }
      },
      {
        "name": "mem",
        "type": "SCALAR",
        "scalar": {
          "value": 128
        }
      }
    ]
  }
}
```


Thanks,

Renan DelValle


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message