aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aurora ReviewBot" <wfar...@apache.org>
Subject Re: Review Request 41486: Deprecate JobUpdateSettings.maxWaitToInstanceRunning and UpdateConfig.restart_threshold
Date Thu, 17 Dec 2015 19:29:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41486/#review111017
-----------------------------------------------------------

Ship it!


Master (c912c34) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Dec. 17, 2015, 6:52 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41486/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2015, 6:52 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1252 and AURORA-1253
>     https://issues.apache.org/jira/browse/AURORA-1252
>     https://issues.apache.org/jira/browse/AURORA-1253
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This pulled a longer thread than i was hoping, since the python class `UpdaterConfig`
was overloaded for use by the rolling restart command.
> 
> Within the scheduler, removal of this field has little behavioral difference.  The effect
is there are some conditions where the scheduler is event-driven instead of polling (which
was more appropriate anyway).
> 
> 
> Diffs
> -----
> 
>   NEWS 7a80f32465736de4fbdc7d2c7a3dbf790be31e16 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift d765dd798e6861e3920802db00e0b96a250d1bfa

>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 9aef59ac5e969b01004d8d9ede825caacca04674

>   src/main/java/org/apache/aurora/scheduler/updater/InstanceActionHandler.java 0880cf2413063c0d1f28e872737872d6e4710bb7

>   src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 0e075607aabdc98a9c8c8c6bfa2929d3428645ff

>   src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java 258151feda2ea0adf0159c24c0e18a7b78b0c390

>   src/main/python/apache/aurora/client/api/__init__.py a6381585a2a9762202f14f929ab922806e84e8b6

>   src/main/python/apache/aurora/client/api/restarter.py 1983034ff4e7510f7c2ca35ff9c851be24637c8e

>   src/main/python/apache/aurora/client/api/updater_util.py b54691eed59854ea5feb4120929cefbf1a95cd24

>   src/main/python/apache/aurora/client/cli/jobs.py ccc52c8357650b126185eb6100b3e2e0e37e1d45

>   src/main/python/apache/aurora/client/hooks/hooked_api.py 6410908b48f54f5188c29f247a9f7797ec802e34

>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java f7f5275bed4eda5e276e408bf253f5da6a9cacd8

>   src/test/python/apache/aurora/client/api/test_api.py 7debc7967cf926bc09f8a93cafa5059c0657e620

>   src/test/python/apache/aurora/client/api/test_restarter.py 7557144ef1eed7ef24e69e82d04494c9f58dc217

>   src/test/python/apache/aurora/client/cli/test_restart.py 2c51d541c4445f287d8794c0117fb038bb776329

>   src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py 97ce9732fd9561327c8c4c4f67fefd3866110bcc

> 
> Diff: https://reviews.apache.org/r/41486/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message