aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 41428: Refactoring HealthCheckConfig into separate structs
Date Wed, 16 Dec 2015 04:40:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41428/#review110612
-----------------------------------------------------------


Looks good overall! A few comments below.


src/main/python/apache/aurora/client/config.py (line 82)
<https://reviews.apache.org/r/41428/#comment170568>

    "...are deprecated and will be removed in next release."
    
    The last sentence needs some rephrasing as well.



src/main/python/apache/aurora/client/config.py (lines 95 - 96)
<https://reviews.apache.org/r/41428/#comment170571>

    Unfinished comments?



src/main/python/apache/aurora/client/config.py (line 97)
<https://reviews.apache.org/r/41428/#comment170572>

    s/to_deprecate/deprecated



src/main/python/apache/aurora/config/schema/base.py (line 39)
<https://reviews.apache.org/r/41428/#comment170570>

    Please, document new fields in configuration-reference.md and mark old ones as deprecated.



src/main/python/apache/aurora/executor/common/health_checker.py (line 234)
<https://reviews.apache.org/r/41428/#comment170575>

    Please, create removal ticket, link it to AURORA-1559 and mention it here.



src/test/python/apache/aurora/client/test_config.py (line 217)
<https://reviews.apache.org/r/41428/#comment170576>

    tabbing is off (here and below)? should be 4 spaces for continuation.



src/test/python/apache/aurora/client/test_config.py (line 241)
<https://reviews.apache.org/r/41428/#comment170577>

    This should be HTTP_DEPRECATION_WARNING from config.py.


- Maxim Khutornenko


On Dec. 16, 2015, 2:13 a.m., Dmitriy Shirchenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41428/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2015, 2:13 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko, Bill Farner, and Zameer Manji.
> 
> 
> Bugs: AURORA-1562
>     https://issues.apache.org/jira/browse/AURORA-1562
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Refactoring HealthCheckConfig into separate structs
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/config.py 161c3627db0afa8fdd8afff5abf6a94556f53180

>   src/main/python/apache/aurora/config/schema/base.py e752482b95ae6377d0cf12cf0ecf0fa60e2a5d46

>   src/main/python/apache/aurora/executor/common/health_checker.py cba4e8c879fae2b9f56a36bf8fa4b702163667d1

>   src/test/python/apache/aurora/client/test_config.py 8fd112fd8a10120f57324d8efec22a009b93404b

>   src/test/python/apache/aurora/executor/common/test_health_checker.py 8561abc3e7df8803785b70064bb76553d3210399

>   src/test/sh/org/apache/aurora/e2e/http/http_example_bad_healthcheck.aurora 37f2e9c6ebc4a4bbd6089e821420e5a02179c6b9

> 
> Diff: https://reviews.apache.org/r/41428/diff/
> 
> 
> Testing
> -------
> 
> Added unit tests.
> 
> 
> Thanks,
> 
> Dmitriy Shirchenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message