aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 41181: Convert test sources to use lambdas throughout.
Date Thu, 10 Dec 2015 18:05:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41181/#review109803
-----------------------------------------------------------

Ship it!


Ship It!

- Maxim Khutornenko


On Dec. 10, 2015, 2:32 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41181/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2015, 2:32 a.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Realized i didn't cover tests in the last pass, this reduces another 1k LOC:
> ```
>  79 files changed, 909 insertions(+), 1935 deletions(-)
> ```
> 
> 
> Diffs
> -----
> 
>   commons/src/test/java/org/apache/aurora/common/args/ArgFiltersTest.java b312bae52e1c7f66366858fb1b3f62554a41528f

>   commons/src/test/java/org/apache/aurora/common/args/ArgScannerTest.java de043041429890409004930f4aa81a9d7a7549ed

>   commons/src/test/java/org/apache/aurora/common/collections/Iterables2Test.java 5b832cd9d43b0da60a8de7ea59af431bbe35c166

>   commons/src/test/java/org/apache/aurora/common/net/http/handlers/TimeSeriesDataSourceTest.java
bdb237feabcf5bce2f9d349eebd0534e63156c01 
>   commons/src/test/java/org/apache/aurora/common/testing/easymock/EasyMockTestTest.java
40c5b8c3f51d7db893fd1352812b0e82acd1821f 
>   commons/src/test/java/org/apache/aurora/common/util/templating/StringTemplateHelperTest.java
0988abce58b414f360fc464c1d4ac04bd8854488 
>   commons/src/test/java/org/apache/aurora/common/zookeeper/GroupTest.java edfc10907b9d5dab86540187c78c25865ead9e41

>   commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetImplTest.java 5eb18e3ed8ea5f725cc5600cfbe44e9fc03abf8b

>   commons/src/test/java/org/apache/aurora/common/zookeeper/SingletonServiceTest.java
167e24259474351e0d9fe2005c5b0526a7fd7c08 
>   commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperClientTest.java e074cf5d41e205ba7bf91964f564aeec1b0db6a8

>   src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java c13a3ba0d28f353d41325686b3031b97d59ffd3a

>   src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 892d6ce6e07bb7ecb40a6b6ed9e843f9f7653f6b

>   src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java 06e22e139b749e8e79126c49127c44729b4e68b3

>   src/jmh/java/org/apache/aurora/benchmark/UpdateStoreBenchmarks.java 9755ee5e336f2c9716851421ee9550ea67faf69e

>   src/jmh/java/org/apache/aurora/benchmark/fakes/FakeStatsProvider.java b1dfc019fb45825a81e52e82654186659e505149

>   src/main/java/org/apache/aurora/scheduler/TaskStatusHandlerImpl.java 09be688060555a83332630019fad8ddd9823a76c

>   src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java 9eda6e9f4582a1fc8a68a0956b12dc1494a5fb76

>   src/main/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImpl.java 675e73dd94ac2309e264b17c04864b900ea3ea2d

>   src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java c4af2fd9ae6ac9988cf676c8d60ad1c0d0d8c3ce

>   src/main/java/org/apache/aurora/scheduler/pruning/JobUpdateHistoryPruner.java f29b7cfea1a4f6f5b7e442cd7b8700637c9b385f

>   src/main/java/org/apache/aurora/scheduler/scheduling/TaskThrottler.java 787309ab030ee5d28932a29e23ca300f611a5130

>   src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java 6a5069f90a2202815ef31be90362f73b8ccbc47b

>   src/main/java/org/apache/aurora/scheduler/storage/backup/Recovery.java 0f0218c44a8b5fb7909edad2f5d56b97effbafe5

>   src/main/java/org/apache/aurora/scheduler/storage/backup/TemporaryStorage.java f683f798c39237932924fcbf45bae2012f5f3dbc

>   src/main/java/org/apache/aurora/scheduler/storage/db/RowGarbageCollector.java 2684054aa601ff33c6cab34c914e966aa0d1bb0d

>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 8aaff22c66d6c6a504464a57496387afa8319298

>   src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 61058c7810f79e6369fe6208a5e2aab2e015b00b

>   src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 94b612731b762ffdc2ff65f3a8dc4ef2a1bf32cc

>   src/test/java/org/apache/aurora/scheduler/ResourceSlotTest.java 175151a111d18a7181558964a62f77e8da6b5b93

>   src/test/java/org/apache/aurora/scheduler/ResourcesTest.java 430e27832f5d28770598ce7a71f95381e3a5dcdc

>   src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java ea67c8d7d2f9b5d2b954f2fefff5688a2e31acd3

>   src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java de4fbbcc929a80cdbd3b6593ad4fedce18a88057

>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 88253d00720ab99d7bf437c9d2758a5c9038478a

>   src/test/java/org/apache/aurora/scheduler/app/local/FakeMaster.java f8940edd2389806899ca75fe9c2851c26810fdc1

>   src/test/java/org/apache/aurora/scheduler/app/local/simulator/FakeSlaves.java 46be83ccd378ee75ee4f1398e392939bd8c017cd

>   src/test/java/org/apache/aurora/scheduler/async/GatingDelayExecutorTest.java c62a1d539bcc2bbddcb4d4bc4f1d1799650426aa

>   src/test/java/org/apache/aurora/scheduler/base/AsyncUtilTest.java 58b4dc914f09a615b2f218efc16102fb81105286

>   src/test/java/org/apache/aurora/scheduler/base/JobsTest.java 986fd01c0885e713e41f0894b7d6c179ef50e118

>   src/test/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJobTest.java be921c3af95e7caa48d7e6e44fcaf640537fd4ea

>   src/test/java/org/apache/aurora/scheduler/cron/quartz/CronIT.java 400f2955c148cd376b7acef2c9ceb3962cd13b09

>   src/test/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImplTest.java 5b0405fed60711c9befa71a526450164e540a1df

>   src/test/java/org/apache/aurora/scheduler/cron/quartz/CronPredictorImplTest.java b879d6f5a394ab016f3b1fc577ac0cf92ef43a3d

>   src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 3794b967223baa9078b43c5dc112bf4ad2ed32d7

>   src/test/java/org/apache/aurora/scheduler/http/LeaderRedirectTest.java b831c9d94c5dd9a78fc5c202c158509071dd01c2

>   src/test/java/org/apache/aurora/scheduler/http/RequestLoggerTest.java 4fd2abe14728bfb7dd4b399e32e2bc0d93229d04

>   src/test/java/org/apache/aurora/scheduler/log/mesos/MesosLogTest.java 9189bde321573f5cc8a751fdd967e50daf5a90a7

>   src/test/java/org/apache/aurora/scheduler/mesos/Offers.java 0e4e008e7057a4a7ce57c3d78b497f51e9e66f6d

>   src/test/java/org/apache/aurora/scheduler/offers/RandomJitterReturnDelayTest.java d446cafc8efedb8c83b13bbf05482972eb2c43a5

>   src/test/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilterTest.java
5cb850814996a9c37a74a231746393e301bd4cf3 
>   src/test/java/org/apache/aurora/scheduler/pruning/TaskHistoryPrunerTest.java 373e8b1e1766dc4bca09f727dd45274214593519

>   src/test/java/org/apache/aurora/scheduler/reconciliation/TaskReconcilerTest.java e6a39acae29fce8cd9427f97612d9cf553035aca

>   src/test/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculatorImplTest.java
71ce376777ce47c3a0f42fe7051041bb0462a152 
>   src/test/java/org/apache/aurora/scheduler/scheduling/TaskGroupsTest.java b9be4ade92f72a0b4bec0789dc65127068b8cd70

>   src/test/java/org/apache/aurora/scheduler/scheduling/TaskSchedulerImplTest.java 13c9f47941eb8ce6c79f3f1a7c530150e3e6fae2

>   src/test/java/org/apache/aurora/scheduler/sla/SlaModuleTest.java 00a872cd56750a44e70b5a4bf988d73a8132ed44

>   src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java 95b22ae5f821b5fb05661e998a68cab018a6f031

>   src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java 01f5273d89d0f35faf3a00a1853326da1b0d62b9

>   src/test/java/org/apache/aurora/scheduler/state/TaskStateMachineTest.java e2c82b7f5a6ca096088b419a7b097ef71e09cc2e

>   src/test/java/org/apache/aurora/scheduler/stats/ResourceCounterTest.java 24dcf6168b74380da2bd79bcfb7f09e8120dd6a2

>   src/test/java/org/apache/aurora/scheduler/storage/AbstractCronJobStoreTest.java 25af7da56e32ad5cc7920b76d91ff29186d2e530

>   src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java fa1d1cd3e718c79e0e6fc88726108bd3eef8086d

>   src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java 2e3ac5ae7d011cf211a4f05afb10b286eb296cfb

>   src/test/java/org/apache/aurora/scheduler/storage/db/DbAttributeStoreTest.java 20c9858d54378ac5ad9f2a8c0a90e246ec90bad9

>   src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java 9d5468c74468e09e6665f499d32d7d4d39e70f1f

>   src/test/java/org/apache/aurora/scheduler/storage/db/DbLockStoreTest.java 400e99fa3940cd6bab1d7cddd21a11969acf70d4

>   src/test/java/org/apache/aurora/scheduler/storage/db/DbQuotaStoreTest.java ff7afcf7828a5c61f5486801a7ed34df6578e0d2

>   src/test/java/org/apache/aurora/scheduler/storage/db/DbSchedulerStoreTest.java 36ff3a5bc60bed478324744f07d2a49745078fdd

>   src/test/java/org/apache/aurora/scheduler/storage/db/DbStorageTest.java a0bd34bbedb4ab004ec602b21fe23983ffd11594

>   src/test/java/org/apache/aurora/scheduler/storage/log/LogManagerTest.java 36900a800b673c87e4cbcffb8e5cf9995e194457

>   src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java cc777b2c976846cf46a34d3262decb53542641f3

>   src/test/java/org/apache/aurora/scheduler/storage/mem/InMemTaskStoreTest.java a39f6906a09143a4eee866081c24f2f4702bb64f

>   src/test/java/org/apache/aurora/scheduler/storage/mem/StorageTransactionTest.java d40e75a66d20ba6372349a5f0787f8ae18934199

>   src/test/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java dcc4ae92716607d6fc9185a473963bdc62382e6e

>   src/test/java/org/apache/aurora/scheduler/testing/FakeScheduledExecutor.java f1f9f771be1f5353774626b7242810f56ea8fc25

>   src/test/java/org/apache/aurora/scheduler/thrift/Fixtures.java 76b047649cf97cd0f868e4091f136240678c096e

>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
1fd106b6f2e3650ddc72f7836f6cd2940eff2527 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdminTest.java
b7555043f6441cd1cfc047f8d8662b5f699d4c18 
>   src/test/java/org/apache/aurora/scheduler/updater/AddTaskTest.java 749e5b857055d2631acbf14b028e3c34def18e39

>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java d98797406d9d5e9de10dbacc7640e513e291b2ff

> 
> Diff: https://reviews.apache.org/r/41181/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message