aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stephan Erb" <step...@dev.static-void.de>
Subject Re: Review Request 41201: Preserve env variables for tasks in docker
Date Thu, 10 Dec 2015 12:38:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41201/#review109748
-----------------------------------------------------------



src/main/python/apache/aurora/executor/thermos_task_runner.py (line 364)
<https://reviews.apache.org/r/41201/#comment169372>

    Is it really necessary that this is implemented docker specific? I believe even if you
don't run docker, one could be interested in that feature.



src/main/python/apache/thermos/core/process.py (line 350)
<https://reviews.apache.org/r/41201/#comment169373>

    This will also override variables like HOME specified above. Is this intended?


- Stephan Erb


On Dec. 10, 2015, 1:24 p.m., Kasisnu Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41201/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2015, 1:24 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Preserve env variables for tasks in docker
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/executor/thermos_task_runner.py 14e8b4bd539d2c295582d93fa01b5613345c1758

>   src/main/python/apache/thermos/core/process.py f214bccbd6f3be795e0fa9a259d27b01b81ab655

>   src/main/python/apache/thermos/core/runner.py f949f279a071c6464b026749f51afc776102f2aa

>   src/main/python/apache/thermos/runner/thermos_runner.py bd8cf7f4cda54b6be72dad64f9446eedeb132211

> 
> Diff: https://reviews.apache.org/r/41201/diff/
> 
> 
> Testing
> -------
> 
> Ran ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh with no failures and did manual
testing for env variables in containers.
> 
> 
> Thanks,
> 
> Kasisnu Singh
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message