aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Sirois" <john.sir...@gmail.com>
Subject Review Request 41140: Revert "Replace manual Forwarding* with `@Forward`."
Date Wed, 09 Dec 2015 16:35:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41140/
-----------------------------------------------------------

Review request for Aurora, Maxim Khutornenko and Bill Farner.


Bugs: AURORA-1146
    https://issues.apache.org/jira/browse/AURORA-1146


Repository: aurora


Description
-------

This reverts commit 0c98e8a82177f39534db3a49162582aeb1739728.

Forward annotation processing was not being handled well by either the
gradle idea task nor the Idea gradle plugin (compile works but test
debugging in the obvious way from the IDE does not).

 build.gradle                                                                  |   3 +-
 src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java        | 185 +++++++++++++++++++++++++++++++++++
 src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java  |  13 +--
 src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java    | 266 ++++++++++++++++++++++++++++++++++++++++++++++++++
 src/test/java/org/apache/aurora/scheduler/thrift/aop/MockDecoratedThrift.java |   5 +-
 5 files changed, 455 insertions(+), 17 deletions(-)


Diffs
-----

  build.gradle fcf8039da96564e8e9a75628b924325616a554a9 
  src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java 2d34f3694a1e47dc4fc15b65f2ae66a1b15abbb4

  src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java PRE-CREATION

  src/test/java/org/apache/aurora/scheduler/thrift/aop/MockDecoratedThrift.java 0547b1acf0c1fc09898fe05777f45cbaa169eea7


Diff: https://reviews.apache.org/r/41140/diff/


Testing
-------

Green: `./gradlew -Pq build`

Also confirmd `./gradlew idea` produced a project I could build from
within IDEA and debug tests with.


Thanks,

John Sirois


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message