aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aurora ReviewBot" <wfar...@apache.org>
Subject Re: Review Request 41056: Upgrade checkstyle and pmd versions.
Date Mon, 07 Dec 2015 23:14:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41056/#review109219
-----------------------------------------------------------


Master (0c98e8a) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Dec. 7, 2015, 10:56 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41056/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2015, 10:56 p.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> We've been holding back on PMD upgades for a while.  This was due to false positives,
but they seem to have been resolved.  With these updates, i believe we can make more extensive
use of lambdas without tripping over QA tools.
> 
> Release notes:
> https://pmd.github.io/pmd-5.4.1/overview/changelog.html
> http://checkstyle.sourceforge.net/releasenotes.html
> 
> 
> Diffs
> -----
> 
>   build.gradle a3ff2b747566a38e5ae07db204d0e75da5d3bfb6 
>   config/pmd/custom.xml c31cac98b14960057905d5224aa23824e48ccf42 
>   src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java 3709c775f80f84d9c4df72d2414c24bf8f6a802b

>   src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java ea43912380f89b4fb06d73c63ec23c47b8f47288

>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 326d4fbc3261c57c44d4dc51d74e05b1155de6ad

>   src/main/java/org/apache/aurora/scheduler/updater/InstanceUpdater.java 0acceaaec851779809adc339a441f33661f9308c

> 
> Diff: https://reviews.apache.org/r/41056/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message