aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aurora ReviewBot" <wfar...@apache.org>
Subject Re: Review Request 40922: AURORA-1548 | (Thermos) Add ability to forward process output to stdout
Date Fri, 04 Dec 2015 08:45:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40922/#review108951
-----------------------------------------------------------


Master (676ee5b) is red with this patch.
  ./build-support/jenkins/build.sh

               Executing tasks in goals: bootstrap -> imports -> unpack-jars -> deferred-sources
-> jvm-platform-validate -> gen -> resolve -> compile -> resources -> test
08:45:33 00:00   [bootstrap]
08:45:33 00:00     [bootstrap-jvm-tools]
08:45:33 00:00   [imports]
08:45:33 00:00     [ivy-imports]
08:45:33 00:00   [unpack-jars]
08:45:33 00:00     [unpack-jars]
08:45:33 00:00   [deferred-sources]
08:45:33 00:00     [deferred-sources]
08:45:33 00:00   [jvm-platform-validate]
08:45:33 00:00     [jvm-platform-validate]
08:45:33 00:00   [gen]
08:45:33 00:00     [thrift]
08:45:33 00:00     [protoc]
08:45:33 00:00     [antlr]
08:45:33 00:00     [ragel]
08:45:33 00:00     [jaxb]
08:45:33 00:00     [wire]
08:45:33 00:00   [resolve]
08:45:33 00:00     [ivy]
08:45:33 00:00       [bootstrap-nailgun-server]
08:45:34 00:01   [compile]
08:45:34 00:01     [python-eval]
08:45:34 00:01     [pythonstyle]
                   Invalidated 112 targets.
T802:WARNING src/test/python/apache/thermos/core/test_process.py:212 open() calls should be
made within a contextmanager.
     |    mock_stdout = open(os.path.join(td, 'mock_stdout'), 'w+')

T802:WARNING src/test/python/apache/thermos/core/test_process.py:213 open() calls should be
made within a contextmanager.
     |    mock_stderr = open(os.path.join(td, 'mock_stderr'), 'w+')

E501:ERROR   src/test/python/apache/thermos/core/test_process.py:218 line too long (112 >
100 characters)
     |    p = TestProcess('process', 'echo hello world; echo >&2 hello stderr', 0,
taskpath, sandbox, log_to_std=True)


FAILURE: Python Style issues found


08:45:52 00:19   [complete]
               FAILURE


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Dec. 4, 2015, 8:07 a.m., Martin Hrabovcin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40922/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2015, 8:07 a.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> AURORA-1548 | (Thermos) Add ability to forward process output to stdout
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 0d02dc1 
>   src/main/python/apache/aurora/executor/thermos_task_runner.py 14e8b4b 
>   src/main/python/apache/thermos/core/process.py fe95cb3 
>   src/main/python/apache/thermos/core/runner.py f949f27 
>   src/main/python/apache/thermos/runner/thermos_runner.py bd8cf7f 
>   src/test/python/apache/thermos/core/test_process.py 5e6ad2f 
> 
> Diff: https://reviews.apache.org/r/40922/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Hrabovcin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message