Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 526D418F13 for ; Mon, 16 Nov 2015 19:37:06 +0000 (UTC) Received: (qmail 37424 invoked by uid 500); 16 Nov 2015 19:37:06 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 37364 invoked by uid 500); 16 Nov 2015 19:37:06 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 37343 invoked by uid 99); 16 Nov 2015 19:37:05 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Nov 2015 19:37:05 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 642CF2902DD; Mon, 16 Nov 2015 19:37:05 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3798976978449719256==" MIME-Version: 1.0 Subject: Re: Review Request 40320: Organize executor-related code into a package. From: "Zameer Manji" To: "Zameer Manji" Cc: "Bill Farner" , "Aurora" Date: Mon, 16 Nov 2015 19:37:05 -0000 Message-ID: <20151116193705.19610.45775@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Zameer Manji" X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/40320/ X-Sender: "Zameer Manji" References: <20151114170026.1634.47778@reviews.apache.org> In-Reply-To: <20151114170026.1634.47778@reviews.apache.org> Reply-To: "Zameer Manji" X-ReviewRequest-Repository: aurora --===============3798976978449719256== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40320/#review106709 ----------------------------------------------------------- Ship it! Ship It! - Zameer Manji On Nov. 14, 2015, 9 a.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40320/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2015, 9 a.m.) > > > Review request for Aurora and Zameer Manji. > > > Repository: aurora > > > Description > ------- > > This is pure code shuffle, the interesting bits coming out of `SchedulerMain` and into `ExecutorModule`. > > Probably should have done this in https://reviews.apache.org/r/40149/, but another follow-up change made it more obvious that this organization was needed. > > > Diffs > ----- > > config/legacy_untested_classes.txt aac822b6e2c022625432e09ad8d4097790429257 > src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java b4ca01b0ae751bdc8fa2d6fb7c667fe3c08ca726 > src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 6236a531b2bb1c9ba09840911ec6d4846cdb9393 > src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java fb4f0a031d3976cbd225fc050487b4002e64ae0c > src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java PRE-CREATION > src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 52776c9cb70127cb88a40f98e2c7cce192b3b5b1 > src/main/java/org/apache/aurora/scheduler/mesos/ExecutorConfig.java b6aa2e1567c79156e1ad7270d430a6fcb282822d > src/main/java/org/apache/aurora/scheduler/mesos/ExecutorSettings.java b7f30231329fe2cf5bc72d11b1f929f394c21c6b > src/main/java/org/apache/aurora/scheduler/mesos/Executors.java 21152f575ed6b0cafe5739df718ef735837b19ac > src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java f1c2059045624ed2486982614f9df14829a00ebc > src/main/java/org/apache/aurora/scheduler/mesos/TestExecutorSettings.java ad5927c9d67749a1a83640ee94d76919640a7949 > src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilter.java b14ab68017b0c66141f6a8bae4b0eacde841a3a2 > src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java da7d1e0dfb6aa8ddf452de79db8bd23491822c89 > src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 50853cfffab832d75f5106742d38a1864d9c6c30 > src/test/java/org/apache/aurora/scheduler/mesos/TaskExecutors.java a258d06cb12b2962d47dbb74a2af29281e255662 > > Diff: https://reviews.apache.org/r/40320/diff/ > > > Testing > ------- > > > Thanks, > > Bill Farner > > --===============3798976978449719256==--