Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B84D318AD5 for ; Sun, 15 Nov 2015 00:28:42 +0000 (UTC) Received: (qmail 90213 invoked by uid 500); 15 Nov 2015 00:28:42 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 90154 invoked by uid 500); 15 Nov 2015 00:28:42 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 90132 invoked by uid 99); 15 Nov 2015 00:28:42 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 15 Nov 2015 00:28:42 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id C019D28FD88; Sun, 15 Nov 2015 00:28:41 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8384739200370243525==" MIME-Version: 1.0 Subject: Re: Review Request 40323: Improve the isolation in the thrift build. From: "Aurora ReviewBot" To: "Bill Farner" , "Zameer Manji" Cc: "Aurora ReviewBot" , "John Sirois" , "Aurora" Date: Sun, 15 Nov 2015 00:28:41 -0000 Message-ID: <20151115002841.1634.34195@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Aurora ReviewBot" X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/40323/ X-Sender: "Aurora ReviewBot" References: <20151114234431.1634.67649@reviews.apache.org> In-Reply-To: <20151114234431.1634.67649@reviews.apache.org> Reply-To: "Aurora ReviewBot" X-ReviewRequest-Repository: aurora --===============8384739200370243525== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40323/#review106550 ----------------------------------------------------------- Ship it! Master (7b494f4) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Nov. 14, 2015, 11:44 p.m., John Sirois wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40323/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2015, 11:44 p.m.) > > > Review request for Aurora, Bill Farner and Zameer Manji. > > > Repository: aurora > > > Description > ------- > > This improves the isolation of the thrift build by building a local > pinned bison dep. For one, this gets thrift 0.9.1 building on Arch > Linux, a rolling release that is otherwise too modern in its libs to > successfully build thrift 0.9.1. > > Additionally, this change knocks out the checksumming TODO and now > checks all downloaded tarballs meet their expected hashes. The > hashes were generated locally after checking the sha1's where > available. > > build-support/thrift/.gitignore | 7 ++++--- > build-support/thrift/Makefile | 47 ++++++++++++++++++++++++++++++++++++++--------- > 2 files changed, 42 insertions(+), 12 deletions(-) > > > Diffs > ----- > > build-support/thrift/.gitignore ad6155ebe8671514b5bf5751f250b6cd71c858b7 > build-support/thrift/Makefile 51f37a959041536004f83a60d038f2116be8c8a9 > > Diff: https://reviews.apache.org/r/40323/diff/ > > > Testing > ------- > > I can now run `./build-support/jenkins/build.sh` green locally. > > I also got a hold of an OSX 10.10.5 box and was able to run > `./build-support/jenkins/build.sh` green on it using this change. > > > Thanks, > > John Sirois > > --===============8384739200370243525==--