Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DB67018183 for ; Thu, 12 Nov 2015 08:35:12 +0000 (UTC) Received: (qmail 73077 invoked by uid 500); 12 Nov 2015 08:35:12 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 73028 invoked by uid 500); 12 Nov 2015 08:35:12 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 72992 invoked by uid 99); 12 Nov 2015 08:35:12 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Nov 2015 08:35:12 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0CF9F1CC389; Thu, 12 Nov 2015 08:35:12 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4508461214693608021==" MIME-Version: 1.0 Subject: Re: Review Request 40220: Modernize the pex venv script. From: "John Sirois" To: "Bill Farner" , "Brian Wickman" , "Kevin Sweeney" Cc: "Aurora ReviewBot" , "John Sirois" , "Aurora" Date: Thu, 12 Nov 2015 08:35:12 -0000 Message-ID: <20151112083512.1680.82583@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "John Sirois" X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/40220/ X-Sender: "John Sirois" References: <20151112082501.1680.79989@reviews.apache.org> In-Reply-To: <20151112082501.1680.79989@reviews.apache.org> Reply-To: "John Sirois" X-ReviewRequest-Repository: aurora --===============4508461214693608021== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40220/ ----------------------------------------------------------- (Updated Nov. 12, 2015, 1:35 a.m.) Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman. Changes ------- Modernize the pex venv script. This converts from grabbing the old `twitter.common.python` pex to grabbing modern pex to match the version specified in 3rdparty to help keep the pex venv up to date with the codebase dependencies. build-support/pex | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) Repository: aurora Description ------- This converts from grabbing the old Twitter python pex to grabbing modern pex to match the version specified in 3rdparty to help keep the pex venv up to date with the codebase dependencies. build-support/pex | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) Diffs (updated) ----- build-support/pex 54e31f11f152cada3809ebd7b2cdec1d2ba12ac9 Diff: https://reviews.apache.org/r/40220/diff/ Testing ------- Locally ran this 2x and observed both the proper version (1.1.0) and proper use of the cached venv in the second run: `git clean -fdx build-support && ./build-support/pex --version` Thanks, John Sirois --===============4508461214693608021==--