Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D210B18B8F for ; Tue, 10 Nov 2015 20:23:02 +0000 (UTC) Received: (qmail 50730 invoked by uid 500); 10 Nov 2015 20:23:02 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 50680 invoked by uid 500); 10 Nov 2015 20:23:02 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 50658 invoked by uid 99); 10 Nov 2015 20:23:02 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Nov 2015 20:23:02 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id F109D27D9B6; Tue, 10 Nov 2015 20:23:01 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1396305784529467551==" MIME-Version: 1.0 Subject: Re: Review Request 39784: Upgrade Aurora to pants 0.0.55. From: "Aurora ReviewBot" To: "Bill Farner" , "Joe Smith" , "Zameer Manji" Cc: "Aurora ReviewBot" , "John Sirois" , "Aurora" Date: Tue, 10 Nov 2015 20:23:01 -0000 Message-ID: <20151110202301.1681.78867@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Aurora ReviewBot" X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/39784/ X-Sender: "Aurora ReviewBot" References: <20151110201709.1680.10937@reviews.apache.org> In-Reply-To: <20151110201709.1680.10937@reviews.apache.org> Reply-To: "Aurora ReviewBot" X-ReviewRequest-Repository: aurora --===============1396305784529467551== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39784/#review105942 ----------------------------------------------------------- Master (3ea1b26) is red with this patch. ./build-support/jenkins/build.sh Running packager against /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/apache.aurora.thrift-0.11.0-SNAPSHOT Writing /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/apache.aurora.thrift-0.11.0-SNAPSHOT.tar.gz Running packager against /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/apache.thermos.thrift-0.11.0-SNAPSHOT Writing /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/apache.thermos.thrift-0.11.0-SNAPSHOT.tar.gz Running packager against /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/apache.thermos.common-0.11.0-SNAPSHOT Writing /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/apache.thermos.common-0.11.0-SNAPSHOT.tar.gz Running packager against /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/apache.thermos.monitoring-0.11.0-SNAPSHOT Writing /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/apache.thermos.monitoring-0.11.0-SNAPSHOT.tar.gz Running packager against /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/apache.thermos.config-0.11.0-SNAPSHOT Writing /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/apache.thermos.config-0.11.0-SNAPSHOT.tar.gz Running packager against /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/apache.thermos.core-0.11.0-SNAPSHOT Writing /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/apache.thermos.core-0.11.0-SNAPSHOT.tar.gz Running packager against /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/apache.aurora.common-0.11.0-SNAPSHOT Writing /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/apache.aurora.common-0.11.0-SNAPSHOT.tar.gz Running packager against /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/apache.aurora.config-0.11.0-SNAPSHOT Writing /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/apache.aurora.config-0.11.0-SNAPSHOT.tar.gz Running packager against /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/apache.aurora.executor-0.11.0-SNAPSHOT Writing /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/apache.aurora.executor-0.11.0-SNAPSHOT.tar.gz 20:17:56 00:03 [complete] SUCCESS INFO] Detected git repository at /home/jenkins/jenkins-slave/workspace/AuroraBot on branch None 20:17:56 00:00 [main] (To run a reporting server: ./pants server) 20:17:56 00:00 [bootstrap] 20:17:56 00:00 [setup] 20:17:56 00:00 [parse] Executing tasks in goals: setup-py 20:17:56 00:00 [setup-py] 20:17:56 00:00 [setup-py] Creating setup.py project for PythonLibrary(BuildFileAddress(FilesystemBuildFile(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/kerberos/BUILD), kerberos)) Creating setup.py project for PythonLibrary(BuildFileAddress(FilesystemBuildFile(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD), common)) Creating setup.py project for PythonLibrary(BuildFileAddress(FilesystemBuildFile(/home/jenkins/jenkins-slave/workspace/AuroraBot/api/src/main/thrift/org/apache/aurora/gen/BUILD), gen)) Creating setup.py project for PythonLibrary(BuildFileAddress(FilesystemBuildFile(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/admin/BUILD), admin)) Creating setup.py project for PythonLibrary(BuildFileAddress(FilesystemBuildFile(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/BUILD), client)) FAILURE: No exported target owner found for PythonLibrary(BuildFileAddress(FilesystemBuildFile(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/resources/apache/aurora/client/cli/BUILD), auroraversion)) 20:17:57 00:01 [complete] FAILURE I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Nov. 10, 2015, 8:17 p.m., John Sirois wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39784/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2015, 8:17 p.m.) > > > Review request for Aurora, Joe Smith, Bill Farner, and Zameer Manji. > > > Bugs: AURORA-1499 > https://issues.apache.org/jira/browse/AURORA-1499 > > > Repository: aurora > > > Description > ------- > > See the changelog here: > https://pypi.python.org/pypi/pantsbuild.pants/0.0.57 > > This also brings Aurora up to pex 1.1.0 and switches to the pants > setup script; an equivalent to gradlew. Of note, the script is checked > in with chmod 555, its not intended to be edited. > > Although pants now includes checkstyle built in, conversion to use it is > left for follow-on work. > > Also adapt make-pycharm-virtualenv which previously relied on the local > bootstrapping of pants - now hidden away by the pants setup script. > > .pantsversion | 1 - > 3rdparty/python/requirements.txt | 2 +- > BUILD | 25 ------------- > BUILD.tools | 19 ++++++++-- > build-support/jenkins/build.sh | 2 +- > build-support/pants_requirements.txt | 30 --------------- > build-support/python/make-pycharm-virtualenv | 11 +++++- > build-support/python/update-pants-requirements | 34 ----------------- > pants | 102 +++++++++++++++++++++++++++++++++++++++----------- > pants.ini | 63 ++----------------------------- > src/main/python/apache/aurora/tools/BUILD | 2 +- > src/main/python/apache/thermos/observer/BUILD | 2 +- > 12 files changed, 114 insertions(+), 179 deletions(-) > > > Diffs > ----- > > .pantsversion 78bae5bb6d254d014e35be0b828497f1509d80bd > 3rdparty/python/requirements.txt 27a2c77047c26ab380fc739e7c5c532bf590c6ee > BUILD 7de0c74b03ba609576867ba96885858c0908f2e9 > BUILD.tools 75698a5ded7914a4d22ab7ae769d9ed1576531e4 > api/src/main/thrift/org/apache/aurora/gen/BUILD 2dcc46d9658044d96f4f1b3634f29ae1d446e0d7 > api/src/main/thrift/org/apache/thermos/BUILD 6b13949aceb830b962a7098ae65462151119d752 > build-support/jenkins/build.sh 5606bb157cb117a588f363382d7c8841ae957138 > build-support/pants_requirements.txt 6eefa7175f7bda7bea23466936e451113a2d86f7 > build-support/python/make-pycharm-virtualenv d7bd41835bcd9a8fe62ea522a177bfa7830a897b > build-support/python/update-pants-requirements 82f7c5136fad52f4bc2a458beb5f34f0cc7f6cec > pants 6f3526ef76fc37e3215b0673bcb1725d205a1c95 > pants.ini dd4ba668586ee5bd1c888f315429e661adb6a480 > src/main/python/apache/aurora/tools/BUILD e5ac75838cbe98bbef4e35f6f300b6a6df5e7de5 > src/main/python/apache/thermos/observer/BUILD d7eedabc0930711530b45ac98a1159e69d1a0c00 > > Diff: https://reviews.apache.org/r/39784/diff/ > > > Testing > ------- > > Locally: `./pants test.pytest --no-fast src/test/python:: -- -v` > > Also generated a pycharm project via: > `./build-support/python/make-pycharm-virtualenv` > Confirmed library source linking worked as did running unit tests > via the IDE. > > Also grepped for pants commands in the repo, found `binary` and `setup-py` > and confirmed these worked. > > > Thanks, > > John Sirois > > --===============1396305784529467551==--