aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Sirois" <john.sir...@gmail.com>
Subject Re: Review Request 40675: Kill extraneous `make clean`.
Date Wed, 25 Nov 2015 03:06:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40675/
-----------------------------------------------------------

(Updated Nov. 24, 2015, 8:06 p.m.)


Review request for Aurora and Bill Farner.


Bugs: AURORA-1545
    https://issues.apache.org/jira/browse/AURORA-1545


Repository: aurora


Description
-------

We're building from a fresh tarball, so there is no need for a clean.
Importantly, the clean breaks building under centos 7 in
aurora-packaging, so this does less work and fixes that case.


Diffs
-----

  build-support/thrift/Makefile 11d597d0a6ffbd7c13aea29803f9b7b38eb3c6df 

Diff: https://reviews.apache.org/r/40675/diff/


Testing
-------

Locally green for `./build-support/thrift/thriftw 0.9.1 --version`
Bill confirmed the fix works for aurora-packaging CentOS 7.


Thanks,

John Sirois


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message