aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 40675: Kill extraneous `make clean`.
Date Tue, 24 Nov 2015 22:15:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40675/#review107856
-----------------------------------------------------------

Ship it!


Ship It!

- Bill Farner


On Nov. 24, 2015, 2:15 p.m., John Sirois wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40675/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2015, 2:15 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> We're building from a fresh tarball, so there is no need for a clean.
> Importantly, the clean breaks building under centos 7 in
> aurora-packaging, so this does less work and fixes that case.
> 
> 
> Diffs
> -----
> 
>   build-support/thrift/Makefile 11d597d0a6ffbd7c13aea29803f9b7b38eb3c6df 
> 
> Diff: https://reviews.apache.org/r/40675/diff/
> 
> 
> Testing
> -------
> 
> Locally green for `./build-support/thrift/thriftw 0.9.1 --version`
> Bill confirmed the fix works for aurora-packaging CentOS 7.
> 
> 
> Thanks,
> 
> John Sirois
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message